Re: [PATCH RFC 4/4] hvmloader:ovmf: setup E820 map

[Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>]

On Fri, Nov 15, 2013 at 03:59:25PM +0000, Wei Liu wrote:
> E820 map will be used by OVMF to create memory map.
> 
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> ---
>  tools/firmware/hvmloader/ovmf.c |   13 ++++++++++++-
>  1 file changed, 12 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/firmware/hvmloader/ovmf.c b/tools/firmware/hvmloader/ovmf.c
> index c253083..52ccd0d 100644
> --- a/tools/firmware/hvmloader/ovmf.c
> +++ b/tools/firmware/hvmloader/ovmf.c
> @@ -128,6 +128,17 @@ static void ovmf_create_smbios_tables(void)
>          SMBIOS_PHYSICAL_END);
>  }
>  
> +static void ovmf_setup_e820(void)
> +{
> +    struct ovmf_info *info = (void *)OVMF_INFO_PHYSICAL_ADDRESS;
> +    struct e820entry *e820 = scratch_alloc(sizeof(struct e820entry)*16, 0);

16? Why not 128 (the default in most kernels)?

> +    info->e820 = (uint32_t)e820;
> +
> +    /* OVMF doesn't load bios image below 0x100000 */
> +    info->e820_nr = build_e820_table(e820, 0, 0xfffff);
> +    dump_e820_table(e820, info->e820_nr);
> +}
> +
>  struct bios_config ovmf_config =  {
>      .name = "OVMF",
>  
> @@ -142,7 +153,7 @@ struct bios_config ovmf_config =  {
>      .bios_info_setup = ovmf_setup_bios_info,
>      .bios_info_finish = ovmf_finish_bios_info,
>  
> -    .e820_setup = NULL,
> +    .e820_setup = ovmf_setup_e820,
>  
>      .acpi_build_tables = ovmf_acpi_build_tables,
>      .create_mp_tables = NULL,
> -- 
> 1.7.10.4
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel