From: Mark Brown <broonie@kernel.org>
To: rtc-linux@googlegroups.com
Cc: Mark Rutland <mark.rutland@arm.com>,
Alessandro Zummo <a.zummo@towertech.it>,
Peter Huewe <peter.huewe@infineon.com>,
Kent Yoder <key@linux.vnet.ibm.com>,
Linus Walleij <linus.walleij@linaro.org>,
Thierry Reding <treding@nvidia.com>,
Rob Herring <rob.herring@calxeda.com>,
Pawel Moll <pawel.moll@arm.com>,
Stephen Warren <swarren@wwwdotorg.org>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Grant Likely <grant.likely@linaro.org>,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
Rob Landley <rob@landley.net>,
Jason Cooper <jason@lakedaemon.net>
Subject: Re: [rtc-linux] [PATCHv2] rtc: Add support for Intersil ISL12057 I2C RTC chip
Date: Wed, 20 Nov 2013 12:45:20 +0000 [thread overview]
Message-ID: <20131120124520.GA2674@sirena.org.uk> (raw)
In-Reply-To: <87k3g5l9gw.fsf@natisbad.org>
[-- Attachment #1: Type: text/plain, Size: 761 bytes --]
On Mon, Nov 18, 2013 at 09:51:27PM +0100, Arnaud Ebalard wrote:
> +/* Block read. Returns 0 on success, or a negative errno. */
> +static int isl12057_i2c_read_regs(struct i2c_client *client, u8 reg, u8 buf[],
> + unsigned len)
This looks like the device would work well with regmap (8 bit register,
8 bit data). This would save a bit of code here both for the I/O
functions and also for some of the debugging functionality you have
below like the proc file.
> + dev_info(dev, "chip found, driver version " DRV_VERSION "\n");
This sort of print is generally frowned upon - it's not adding anything
to the message already displayed by the RTC core on registration. It's
probably best to remove the driver version too, the kernel is already
versioned.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-11-20 12:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-18 20:51 [PATCHv2] rtc: Add support for Intersil ISL12057 I2C RTC chip Arnaud Ebalard
2013-11-20 12:45 ` Mark Brown [this message]
2013-11-21 22:00 ` Arnaud Ebalard
2013-11-22 12:47 ` [rtc-linux] " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131120124520.GA2674@sirena.org.uk \
--to=broonie@kernel.org \
--cc=a.zummo@towertech.it \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jason@lakedaemon.net \
--cc=key@linux.vnet.ibm.com \
--cc=linus.walleij@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=peter.huewe@infineon.com \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=rtc-linux@googlegroups.com \
--cc=swarren@wwwdotorg.org \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.