From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Jan Engelhardt <jengelh@inai.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 2/3] build: rename conflicting parser.h instances
Date: Wed, 20 Nov 2013 15:02:06 +0100 [thread overview]
Message-ID: <20131120140206.GA7599@localhost> (raw)
In-Reply-To: <alpine.LSU.2.11.1311201002440.24243@nerf07.vanv.qr>
On Wed, Nov 20, 2013 at 10:06:39AM +0100, Jan Engelhardt wrote:
> On Tuesday 2013-11-19 21:25, Pablo Neira Ayuso wrote:
>
> >On Sun, Oct 20, 2013 at 04:48:10PM +0200, Jan Engelhardt wrote:
> >> If -I. is on the command line, #include <parser.h> becomes ./parser.h
> >> instead of ../include/parser.h.
> >
> >What use case are you trying to handle with this?
> >
> automake adds -I${builddir} -I${srcdir} and -I{dir with config.h} to the
> command line. Because both ${builddir} and -I${top_srcdir}/include
> (which is also being passed, this time by Makefile.am), #include
> <parser.h> becomes sort of ambiguous (the compiler knows which one to
> pick, but it's not the one to success).
OK, then you need this patch to get patch 3/3 working, since automake
it currently not used. That was unclear in the patch description.
next prev parent reply other threads:[~2013-11-20 14:02 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-20 14:48 nftables: use automake & pkgconfig Jan Engelhardt
2013-10-20 14:48 ` [PATCH 1/3] build: remove unused checks Jan Engelhardt
2013-11-19 20:24 ` Pablo Neira Ayuso
2013-10-20 14:48 ` [PATCH 2/3] build: rename conflicting parser.h instances Jan Engelhardt
2013-11-19 20:25 ` Pablo Neira Ayuso
2013-11-20 9:06 ` Jan Engelhardt
2013-11-20 14:02 ` Pablo Neira Ayuso [this message]
2013-10-20 14:48 ` [PATCH 3/3] build: use automake and pkgconfig Jan Engelhardt
2013-11-19 20:28 ` Pablo Neira Ayuso
2013-11-20 10:54 ` Jan Engelhardt
2013-11-20 11:11 ` Tomasz Bursztyka
2013-11-20 13:54 ` Pablo Neira Ayuso
2013-11-20 14:06 ` Pablo Neira Ayuso
2013-11-20 14:14 ` Jan Engelhardt
2013-12-06 17:47 ` Jan Engelhardt
2013-11-17 20:39 ` nftables: use automake & pkgconfig Jan Engelhardt
-- strict thread matches above, loose matches on Subject: below --
2014-01-13 9:07 nftables: improve build system Jan Engelhardt
2014-01-13 9:07 ` [PATCH 2/3] build: rename conflicting parser.h instances Jan Engelhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131120140206.GA7599@localhost \
--to=pablo@netfilter.org \
--cc=jengelh@inai.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.