From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Horman Date: Thu, 21 Nov 2013 05:02:07 +0000 Subject: Re: [PATCH v2 7/7] ARM: shmobile: armadillo-reference: Use low level IRQ for ST1231 Message-Id: <20131121050207.GW31130@verge.net.au> List-Id: References: <1383999839-3339-8-git-send-email-laurent.pinchart+renesas@ideasonboard.com> <1384865989-12875-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com> In-Reply-To: <1384865989-12875-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org On Tue, Nov 19, 2013 at 01:59:49PM +0100, Laurent Pinchart wrote: > The device is configured to generate an active-low interrupt signal that > needs to be acknowledged by the host. Configure the IRQ to trigger on > low level. > > Signed-off-by: Laurent Pinchart > --- > arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > Changes since v1: > > - Fixed typo (IRQ_TYPE_LOW_LEVEL -> IRQ_TYPE_LEVEL_LOW) Thanks, I will queue this up. Assuming all goes will I plan to push this and other updates today or tomorrow. > > diff --git a/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts b/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts > index aef425f..7b80f19 100644 > --- a/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts > +++ b/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts > @@ -95,7 +95,7 @@ > compatible = "sitronix,st1232"; > reg = <0x55>; > interrupt-parent = <&irqpin1>; > - interrupts = <2 IRQ_TYPE_NONE>; /* IRQ10: hwirq 2 on irqpin1 */ > + interrupts = <2 IRQ_TYPE_LEVEL_LOW>; > pinctrl-0 = <&st1232_pins>; > pinctrl-names = "default"; > gpios = <&pfc 166 GPIO_ACTIVE_LOW>; > -- > 1.8.3.2 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-sh" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > From mboxrd@z Thu Jan 1 00:00:00 1970 From: horms@verge.net.au (Simon Horman) Date: Thu, 21 Nov 2013 14:02:07 +0900 Subject: [PATCH v2 7/7] ARM: shmobile: armadillo-reference: Use low level IRQ for ST1231 In-Reply-To: <1384865989-12875-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com> References: <1383999839-3339-8-git-send-email-laurent.pinchart+renesas@ideasonboard.com> <1384865989-12875-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com> Message-ID: <20131121050207.GW31130@verge.net.au> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Nov 19, 2013 at 01:59:49PM +0100, Laurent Pinchart wrote: > The device is configured to generate an active-low interrupt signal that > needs to be acknowledged by the host. Configure the IRQ to trigger on > low level. > > Signed-off-by: Laurent Pinchart > --- > arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > Changes since v1: > > - Fixed typo (IRQ_TYPE_LOW_LEVEL -> IRQ_TYPE_LEVEL_LOW) Thanks, I will queue this up. Assuming all goes will I plan to push this and other updates today or tomorrow. > > diff --git a/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts b/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts > index aef425f..7b80f19 100644 > --- a/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts > +++ b/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts > @@ -95,7 +95,7 @@ > compatible = "sitronix,st1232"; > reg = <0x55>; > interrupt-parent = <&irqpin1>; > - interrupts = <2 IRQ_TYPE_NONE>; /* IRQ10: hwirq 2 on irqpin1 */ > + interrupts = <2 IRQ_TYPE_LEVEL_LOW>; > pinctrl-0 = <&st1232_pins>; > pinctrl-names = "default"; > gpios = <&pfc 166 GPIO_ACTIVE_LOW>; > -- > 1.8.3.2 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-sh" in > the body of a message to majordomo at vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Horman Subject: Re: [PATCH v2 7/7] ARM: shmobile: armadillo-reference: Use low level IRQ for ST1231 Date: Thu, 21 Nov 2013 14:02:07 +0900 Message-ID: <20131121050207.GW31130@verge.net.au> References: <1383999839-3339-8-git-send-email-laurent.pinchart+renesas@ideasonboard.com> <1384865989-12875-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1384865989-12875-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com> Sender: linux-sh-owner@vger.kernel.org To: Laurent Pinchart Cc: linux-sh@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Kuninori Morimoto List-Id: devicetree@vger.kernel.org On Tue, Nov 19, 2013 at 01:59:49PM +0100, Laurent Pinchart wrote: > The device is configured to generate an active-low interrupt signal that > needs to be acknowledged by the host. Configure the IRQ to trigger on > low level. > > Signed-off-by: Laurent Pinchart > --- > arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > Changes since v1: > > - Fixed typo (IRQ_TYPE_LOW_LEVEL -> IRQ_TYPE_LEVEL_LOW) Thanks, I will queue this up. Assuming all goes will I plan to push this and other updates today or tomorrow. > > diff --git a/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts b/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts > index aef425f..7b80f19 100644 > --- a/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts > +++ b/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts > @@ -95,7 +95,7 @@ > compatible = "sitronix,st1232"; > reg = <0x55>; > interrupt-parent = <&irqpin1>; > - interrupts = <2 IRQ_TYPE_NONE>; /* IRQ10: hwirq 2 on irqpin1 */ > + interrupts = <2 IRQ_TYPE_LEVEL_LOW>; > pinctrl-0 = <&st1232_pins>; > pinctrl-names = "default"; > gpios = <&pfc 166 GPIO_ACTIVE_LOW>; > -- > 1.8.3.2 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-sh" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >