From: Nishanth Menon <nm@ti.com>
To: Stefan Roese <mail@roese.nl>
Cc: Paul Walmsley <paul@pwsan.com>, "Nayak, Rajendra" <rnayak@ti.com>,
"tony@atomide.com" <tony@atomide.com>, Suman Anna <s-anna@ti.com>,
linux-omap <linux-omap@vger.kernel.org>
Subject: Re: AM335x board with disabled RTC crashes
Date: Wed, 20 Nov 2013 23:30:06 -0600 [thread overview]
Message-ID: <20131121053006.GA19129@kahuna> (raw)
In-Reply-To: <528D8CF0.1050406@roese.nl>
On 05:32-20131121, Stefan Roese wrote:
> On 11/21/2013 05:28 AM, Stefan Roese wrote:
> >>>> Disabling the RTC in the DT doesn't help (of course). So what's the
> >>>> recommended way to disable this hwmod access to the RTC registers?
> >>>
> >>>
> >>> http://www.spinics.net/lists/linux-omap/msg98207.html
> >>> might help you - we had thought it might get queued for 3.12, but it
> >>> was queued for 3.13 instead..
> >
> > Unfortunately this patch doesn't fix the crash for me (yet). With this
> > patch applied and the RTC DT node completely removed from am33xx.dtsi it
> > works. But only disabling it (via status = "disabled" in the board dts
> > file) doesn't work.
> >
> > I'll dig a bit deeper today...
>
> This (hacky) patch works, but I'm not sure if this is acceptable upstream:
>
> am335x-board_foo.dts:
>
> ...
>
> &rtc {
> reg = <0x0 0x0>;
> };
>
You should be able to achieve the same effect as following (example from
BBB) - though I dont see this defined in
Documentation/devicetree/bindings/arm/omap/omap.txt
I will allow the wisdom of others to comment better here :)
diff --git a/arch/arm/boot/dts/am335x-boneblack.dts b/arch/arm/boot/dts/am335x-boneblack.dts
index 6b71ad9..a734ef4 100644
--- a/arch/arm/boot/dts/am335x-boneblack.dts
+++ b/arch/arm/boot/dts/am335x-boneblack.dts
@@ -66,6 +66,11 @@
status = "okay";
};
+&am335xrtc {
+ status = "disabled";
+ ti,hwmods="disabled";
+};
+
/ {
hdmi {
compatible = "ti,tilcdc,slave";
diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
index f6d8ffe..71bf2ec 100644
--- a/arch/arm/boot/dts/am33xx.dtsi
+++ b/arch/arm/boot/dts/am33xx.dtsi
@@ -373,7 +373,7 @@
ti,timer-pwm;
};
- rtc@44e3e000 {
+ am335xrtc: rtc@44e3e000 {
compatible = "ti,da830-rtc";
reg = <0x44e3e000 0x1000>;
interrupts = <75
--
Regards,
Nishanth Menon
next prev parent reply other threads:[~2013-11-21 5:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-20 14:18 AM335x board with disabled RTC crashes Stefan Roese
2013-11-20 14:22 ` Nishanth Menon
[not found] ` <528CDAF6.7070905@ti.com>
2013-11-21 4:28 ` Stefan Roese
2013-11-21 4:32 ` Stefan Roese
2013-11-21 5:30 ` Nishanth Menon [this message]
2013-11-21 5:42 ` Stefan Roese
2013-11-21 5:52 ` Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131121053006.GA19129@kahuna \
--to=nm@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=mail@roese.nl \
--cc=paul@pwsan.com \
--cc=rnayak@ti.com \
--cc=s-anna@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.