All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
To: Jean-Jacques Hiblot <jjhiblot-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Gregory CLEMENT
	<gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
	linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] i2c : i2c-ibm-iic : use interrupts to perform the data transfer
Date: Thu, 21 Nov 2013 11:43:11 +0100	[thread overview]
Message-ID: <20131121104311.GA5013@katana> (raw)
In-Reply-To: <528DD837.5060005-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 347 bytes --]

Hi,

I haven't reviewed the patch itself yet, just noticed the discussion.

> >
> >>+		if (ext_status & EXTSTS_LA)
> >>+			dev_dbg(dev->dev, "Lost arbitration\n");
> >
> >Ditto
> I don't know if this is really an error. Arbitration loss wan be very
> common in a multi master environement. What about dev_warn ou dev_info

I think a dbg is okay.


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  parent reply	other threads:[~2013-11-21 10:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-20 15:08 [PATCH] i2c : i2c-ibm-iic : use interrupts to perform the data transfer jean-jacques hiblot
     [not found] ` <1384960134-24039-1-git-send-email-jean-jacques.hiblot-qU79poH1Kb0@public.gmane.org>
2013-11-20 15:53   ` Gregory CLEMENT
     [not found]     ` <528CDAEC.3040307-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2013-11-21  9:53       ` Jean-Jacques Hiblot
     [not found]         ` <528DD837.5060005-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-11-21 10:43           ` Wolfram Sang [this message]
2013-11-21 12:16           ` Gregory CLEMENT

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131121104311.GA5013@katana \
    --to=wsa-z923lk4zbo2bacvfa/9k2g@public.gmane.org \
    --cc=gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
    --cc=jjhiblot-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.