From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from comal.ext.ti.com (comal.ext.ti.com [198.47.26.152]) by arago-project.org (Postfix) with ESMTPS id D9342529CE for ; Thu, 21 Nov 2013 14:37:16 +0000 (UTC) Received: from dflxv15.itg.ti.com ([128.247.5.124]) by comal.ext.ti.com (8.13.7/8.13.7) with ESMTP id rALEbF1f019459 for ; Thu, 21 Nov 2013 08:37:15 -0600 Received: from DFLE73.ent.ti.com (dfle73.ent.ti.com [128.247.5.110]) by dflxv15.itg.ti.com (8.14.3/8.13.8) with ESMTP id rALEbFTs005615 for ; Thu, 21 Nov 2013 08:37:15 -0600 Received: from dlep33.itg.ti.com (157.170.170.75) by DFLE73.ent.ti.com (128.247.5.110) with Microsoft SMTP Server id 14.2.342.3; Thu, 21 Nov 2013 08:37:15 -0600 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by dlep33.itg.ti.com (8.14.3/8.13.8) with ESMTP id rALEbFxk000530; Thu, 21 Nov 2013 08:37:15 -0600 Date: Thu, 21 Nov 2013 09:37:14 -0500 From: Denys Dmytriyenko To: "Cooper Jr., Franklin" Message-ID: <20131121143714.GM29952@edge> References: <1384887728-8628-1-git-send-email-fcooper@ti.com> <1384887728-8628-7-git-send-email-fcooper@ti.com> <20131121045508.GJ29952@edge> <8F29D6B095ED194EA1980491A5E029710C5BB87B@DFLE08.ent.ti.com> MIME-Version: 1.0 In-Reply-To: <8F29D6B095ED194EA1980491A5E029710C5BB87B@DFLE08.ent.ti.com> User-Agent: Mutt/1.5.20 (2009-06-14) Cc: "meta-arago@arago-project.org" Subject: Re: [PATCH 7/7] packagegroup-arago-tisdk-matrix: Add additional example application for AM43x X-BeenThere: meta-arago@arago-project.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Arago metadata layer for TI SDKs - OE-Core/Yocto compatible List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Nov 2013 14:37:18 -0000 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline On Thu, Nov 21, 2013 at 07:46:41AM -0500, Cooper Jr., Franklin wrote: > > > > -----Original Message----- > > From: Dmytriyenko, Denys > > Sent: Wednesday, November 20, 2013 10:55 PM > > To: Cooper Jr., Franklin > > Cc: meta-arago@arago-project.org > > Subject: Re: [meta-arago] [PATCH 7/7] packagegroup-arago-tisdk-matrix: Add > > additional example application for AM43x > > > > On Tue, Nov 19, 2013 at 01:02:08PM -0600, Franklin S. Cooper Jr wrote: > > > * Add additional example applications for AM43x. > > > > > > Signed-off-by: Franklin S. Cooper Jr > > > --- > > > .../packagegroup-arago-tisdk-matrix.bb | 8 +++++++- > > > 1 files changed, 7 insertions(+), 1 deletions(-) > > > > > > diff --git > > > a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisd > > > k-matrix.bb > > > b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisd > > > k-matrix.bb > > > index 95054b2..c3143d3 100644 > > > --- > > > a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisd > > > k-matrix.bb > > > +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago- > > > +++ tisdk-matrix.bb > > > @@ -1,6 +1,6 @@ > > > DESCRIPTION = "Task to include Matrix v2" > > > LICENSE = "MIT" > > > -PR = "r22" > > > +PR = "r23" > > > > > > inherit packagegroup > > > > > > @@ -72,10 +72,16 @@ MATRIX_APPS_append_ti33x = " \ > > > # matrix-gui-wifi-direct-demo > > > > > > MATRIX_APPS_append_ti43x = " \ > > > + > > > + > > ${@base_contains('MACHINE_FEATURES','sgx','${MATRIX_SGX_DEMOS}','',d > > > + )} \ > > > > So, I just noticed, that in patch #3 of this series, you add SGX libgles > > unconditionally, but here you do check for the proper MACHINE_FEATURE... > > > > Should it be one way or another? If you update patch #3 with conditional like > > here, the whole series can be pushed even prior to the new SGX in meta-ti... > [Franklin] The changes in patch three simply mimics what we have always been > doing right or wrong for other devices. Since the entire recipe is specific > to sgx we move the conditional check to the packagegroup/image that these > recipes are included in. Packagegroup-arago-toolchain-tisdk-target includes > packagegroup-arago-tisdk-graphics conditional based on MACHINE_FEATURE. > Likewise tisdk-rootfs-image includes packagegroup-arago-tisdk-graphics > conditional based on MACHINE_FEATURE. > > As is it should still be fine but you still want it changed I can but I > should make the change for all the machines as well. Ah, good point. If the checks are made outside in higher-level packagegroups, then it's fine with me and I'll try to push the patches after verifying that... > > > matrix-multimedia-demo-aac \ > > > matrix-multimedia-demo-h264dec \ > > > matrix-multimedia-demo-mpeg4aacdec \ > > > matrix-multimedia-demo-mpeg4dec \ > > > + \ > > > + matrix-gui-generic-pm \ > > > + matrix-gui-pm-demos-suspend \ > > > + matrix-gui-clocks \ > > > " > > > > > > MATRIX_APPS_append_omap-a15 = " \ > > > -- > > > 1.7.0.4 > > > > > > _______________________________________________ > > > meta-arago mailing list > > > meta-arago@arago-project.org > > > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago