From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail.skyhub.de ([2a01:4f8:120:8448::d00d]) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1VjXS2-0008N7-MJ for kexec@lists.infradead.org; Thu, 21 Nov 2013 16:49:59 +0000 Date: Thu, 21 Nov 2013 17:49:29 +0100 From: Borislav Petkov Subject: Re: [patch 4/9 v3] efi: cleanup efi_enter_virtual_mode function Message-ID: <20131121164929.GM26009@pd.tnic> References: <20131121061704.363730447@dhcp-16-126.nay.redhat.com> <20131121061754.304016344@dhcp-16-126.nay.redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20131121061754.304016344@dhcp-16-126.nay.redhat.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "kexec" Errors-To: kexec-bounces+dwmw2=twosheds.infradead.org@lists.infradead.org To: dyoung@redhat.com Cc: mjg59@srcf.ucam.org, linux-efi@vger.kernel.org, toshi.kani@hp.com, matt@console-pimps.org, greg@kroah.com, x86@kernel.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, James.Bottomley@HansenPartnership.com, horms@verge.net.au, ebiederm@xmission.com, hpa@zytor.com, vgoyal@redhat.com T24gVGh1LCBOb3YgMjEsIDIwMTMgYXQgMDI6MTc6MDhQTSArMDgwMCwgZHlvdW5nQHJlZGhhdC5j b20gd3JvdGU6Cj4gQWRkIHR3byBzbWFsbCBmdW5jdGlvbnM6Cj4gZWZpX21lcmdlX3JlZ2lvbnMg YW5kIGVmaV9tYXBfcmVnaW9ucywgZWZpX2VudGVyX3ZpcnR1YWxfbW9kZQo+IGNhbGxzIHRoZW0g aW5zdGVhZCBvZiBlbWJlZGRpbmcgdHdvIGxvbmcgZm9yIGxvb3AuCj4gCj4gdjEtPnYyOgo+IHJl ZnJlc2g7IGNvZGluZyBzdHlsZSBmaXhlcy4KPiAKPiB2Mi0+djM6Cj4gVG9zaGkgS2FuaToKPiBy ZW1vdmUgdW51c2VkIHZhcmlhYmxlCj4gTWF0dDogY2hlY2sgcmV0dXJuIHZhbHVlIG9mIGtyZWFs bG9jLgo+IAo+IFNpZ25lZC1vZmYtYnk6IERhdmUgWW91bmcgPGR5b3VuZ0ByZWRoYXQuY29tPgoK U2FtZSBzaG9ydCBjb21tZW50IG5pdHBpY2sgYXMgZWFybGllciA6KQoKT3RoZXJ3aXNlOgoKQWNr ZWQtYnk6IEJvcmlzbGF2IFBldGtvdiA8YnBAc3VzZS5kZT4KCj4gLS0tCj4gIGFyY2gveDg2L3Bs YXRmb3JtL2VmaS9lZmkuYyB8ICAxMDkgKysrKysrKysrKysrKysrKysrKysrKysrKystLS0tLS0t LS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDY2IGluc2VydGlvbnMoKyksIDQzIGRlbGV0 aW9ucygtKQo+IAo+IC0tLSBlZmkub3JpZy9hcmNoL3g4Ni9wbGF0Zm9ybS9lZmkvZWZpLmMKPiAr KysgZWZpL2FyY2gveDg2L3BsYXRmb3JtL2VmaS9lZmkuYwoKWyDigKYgXQoKPiBAQCAtODM3LDYg KzgwNSwxOCBAQCB2b2lkIF9faW5pdCBlZmlfZW50ZXJfdmlydHVhbF9tb2RlKHZvaWQpCj4gIAkJ cHJldl9tZCA9IG1kOwo+ICAKPiAgCX0KPiArfQo+ICsKPiArLyoKPiArICogTWFwIGVmaSBtZW1v cnkgcmFuZ2VzIGZvciBydW50aW1lIHNlcml2Y2UgYW5kCj4gKyAqIHVwZGF0ZSBuZXdfbWVtbWFw IHdpdGggdmlydHVhbCBhZGRyZXNzZXMuCj4gKyAqLwoKU3RyZXRjaCBjb21tZW50IHRvIDgwIGNv bHM6CgovKgogKiBNYXAgZWZpIG1lbW9yeSByYW5nZXMgZm9yIHJ1bnRpbWUgc2VyaXZjZSBhbmQg dXBkYXRlIG5ld19tZW1tYXAgd2l0aCB2aXJ0dWFsCiAqIGFkZHJlc3Nlcy4KICovCgpsaWtlIGl0 IGlzIGN1c3RvbWFyeSBmb3IgdGhlIHJlc3Qgb2YgdGhlIGZpbGUuCgo+ICtzdGF0aWMgdm9pZCAq IF9faW5pdCBlZmlfbWFwX3JlZ2lvbnMoaW50ICpjb3VudCkKPiArewo+ICsJZWZpX21lbW9yeV9k ZXNjX3QgKm1kOwo+ICsJdm9pZCAqcCwgKm5ld19tZW1tYXAgPSBOVUxMOwo+ICsJdW5zaWduZWQg bG9uZyBzaXplOwo+ICsJdTY0IGVuZCwgc3lzdGFiOwo+ICAKPiAgCWZvciAocCA9IG1lbW1hcC5t YXA7IHAgPCBtZW1tYXAubWFwX2VuZDsgcCArPSBtZW1tYXAuZGVzY19zaXplKSB7Cj4gIAkJbWQg PSBwOwoKLS0gClJlZ2FyZHMvR3J1c3MsCiAgICBCb3Jpcy4KClNlbnQgZnJvbSBhIGZhdCBjcmF0 ZSB1bmRlciBteSBkZXNrLiBGb3JtYXR0aW5nIGlzIGZpbmUuCi0tCgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwprZXhlYyBtYWlsaW5nIGxpc3QKa2V4ZWNA bGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2tleGVjCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: Borislav Petkov Subject: Re: [patch 4/9 v3] efi: cleanup efi_enter_virtual_mode function Date: Thu, 21 Nov 2013 17:49:29 +0100 Message-ID: <20131121164929.GM26009@pd.tnic> References: <20131121061704.363730447@dhcp-16-126.nay.redhat.com> <20131121061754.304016344@dhcp-16-126.nay.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <20131121061754.304016344@dhcp-16-126.nay.redhat.com> Sender: linux-kernel-owner@vger.kernel.org To: dyoung@redhat.com Cc: linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org, x86@kernel.org, mjg59@srcf.ucam.org, hpa@zytor.com, James.Bottomley@HansenPartnership.com, vgoyal@redhat.com, ebiederm@xmission.com, horms@verge.net.au, kexec@lists.infradead.org, greg@kroah.com, matt@console-pimps.org, toshi.kani@hp.com List-Id: linux-efi@vger.kernel.org On Thu, Nov 21, 2013 at 02:17:08PM +0800, dyoung@redhat.com wrote: > Add two small functions: > efi_merge_regions and efi_map_regions, efi_enter_virtual_mode > calls them instead of embedding two long for loop. >=20 > v1->v2: > refresh; coding style fixes. >=20 > v2->v3: > Toshi Kani: > remove unused variable > Matt: check return value of krealloc. >=20 > Signed-off-by: Dave Young Same short comment nitpick as earlier :) Otherwise: Acked-by: Borislav Petkov > --- > arch/x86/platform/efi/efi.c | 109 ++++++++++++++++++++++++++-------= ----------- > 1 file changed, 66 insertions(+), 43 deletions(-) >=20 > --- efi.orig/arch/x86/platform/efi/efi.c > +++ efi/arch/x86/platform/efi/efi.c [ =E2=80=A6 ] > @@ -837,6 +805,18 @@ void __init efi_enter_virtual_mode(void) > prev_md =3D md; > =20 > } > +} > + > +/* > + * Map efi memory ranges for runtime serivce and > + * update new_memmap with virtual addresses. > + */ Stretch comment to 80 cols: /* * Map efi memory ranges for runtime serivce and update new_memmap with= virtual * addresses. */ like it is customary for the rest of the file. > +static void * __init efi_map_regions(int *count) > +{ > + efi_memory_desc_t *md; > + void *p, *new_memmap =3D NULL; > + unsigned long size; > + u64 end, systab; > =20 > for (p =3D memmap.map; p < memmap.map_end; p +=3D memmap.desc_size)= { > md =3D p; --=20 Regards/Gruss, Boris. Sent from a fat crate under my desk. Formatting is fine. --