From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ralf Baechle Date: Thu, 21 Nov 2013 17:39:33 +0000 Subject: Re: [PATCH 24/34] PCI: use weak functions for MSI arch-specific functions Message-Id: <20131121173933.GT10382@linux-mips.org> List-Id: References: <1384915853-31006-1-git-send-email-r65037@freescale.com> <1384915853-31006-24-git-send-email-r65037@freescale.com> In-Reply-To: <1384915853-31006-24-git-send-email-r65037@freescale.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Richard Zhu Cc: Thomas Petazzoni , Benjamin Herrenschmidt , Paul Mackerras , linuxppc-dev@lists.ozlabs.org, Martin Schwidefsky , Heiko Carstens , linux390@de.ibm.com, linux-s390@vger.kernel.org, Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, Russell King , Tony Luck , Fenghua Yu , linux-ia64@vger.kernel.org, linux-mips@linux-mips.org, "David S. Miller" , sparclinux@vger.kernel.org, Chris Metcalf , Jason Cooper On Wed, Nov 20, 2013 at 10:50:43AM +0800, Richard Zhu wrote: Looking good, Acked-by: Ralf Baechle Nevertheless I'd again like to express that I'm not that fond of of the increasing number of weak functions in the kernel. In the old days things were such that when an a platform didn't provice a platform hook or enable a default hook function, one would get a build error - an unmistakable sign to the maintainer that something needs attention. Weak functions mean default functions may result in subtly incorrect operation. Been there, got bitten. Ralf From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Thu, 21 Nov 2013 18:40:02 +0100 (CET) Received: from localhost.localdomain ([127.0.0.1]:33625 "EHLO linux-mips.org" rhost-flags-OK-OK-OK-FAIL) by eddie.linux-mips.org with ESMTP id S6867239Ab3KURkAT3jwE (ORCPT ); Thu, 21 Nov 2013 18:40:00 +0100 Received: from scotty.linux-mips.net (localhost.localdomain [127.0.0.1]) by scotty.linux-mips.net (8.14.7/8.14.4) with ESMTP id rALHdkEI019033; Thu, 21 Nov 2013 18:39:46 +0100 Received: (from ralf@localhost) by scotty.linux-mips.net (8.14.7/8.14.7/Submit) id rALHdXvD019024; Thu, 21 Nov 2013 18:39:33 +0100 Date: Thu, 21 Nov 2013 18:39:33 +0100 From: Ralf Baechle To: Richard Zhu Cc: Thomas Petazzoni , Benjamin Herrenschmidt , Paul Mackerras , linuxppc-dev@lists.ozlabs.org, Martin Schwidefsky , Heiko Carstens , linux390@de.ibm.com, linux-s390@vger.kernel.org, Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, Russell King , Tony Luck , Fenghua Yu , linux-ia64@vger.kernel.org, linux-mips@linux-mips.org, "David S. Miller" , sparclinux@vger.kernel.org, Chris Metcalf , Jason Cooper Subject: Re: [PATCH 24/34] PCI: use weak functions for MSI arch-specific functions Message-ID: <20131121173933.GT10382@linux-mips.org> References: <1384915853-31006-1-git-send-email-r65037@freescale.com> <1384915853-31006-24-git-send-email-r65037@freescale.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1384915853-31006-24-git-send-email-r65037@freescale.com> User-Agent: Mutt/1.5.21 (2010-09-15) Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 38565 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: ralf@linux-mips.org Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On Wed, Nov 20, 2013 at 10:50:43AM +0800, Richard Zhu wrote: Looking good, Acked-by: Ralf Baechle Nevertheless I'd again like to express that I'm not that fond of of the increasing number of weak functions in the kernel. In the old days things were such that when an a platform didn't provice a platform hook or enable a default hook function, one would get a build error - an unmistakable sign to the maintainer that something needs attention. Weak functions mean default functions may result in subtly incorrect operation. Been there, got bitten. Ralf From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from git.linux-mips.org (marvin.linux-mips.org [78.24.191.183]) by ozlabs.org (Postfix) with ESMTP id 5723F2C00C6 for ; Fri, 22 Nov 2013 04:55:57 +1100 (EST) Received: from localhost.localdomain ([127.0.0.1]:33627 "EHLO linux-mips.org" rhost-flags-OK-OK-OK-FAIL) by eddie.linux-mips.org with ESMTP id S6867243Ab3KURkBobykT (ORCPT ); Thu, 21 Nov 2013 18:40:01 +0100 Date: Thu, 21 Nov 2013 18:39:33 +0100 From: Ralf Baechle To: Richard Zhu Subject: Re: [PATCH 24/34] PCI: use weak functions for MSI arch-specific functions Message-ID: <20131121173933.GT10382@linux-mips.org> References: <1384915853-31006-1-git-send-email-r65037@freescale.com> <1384915853-31006-24-git-send-email-r65037@freescale.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1384915853-31006-24-git-send-email-r65037@freescale.com> Cc: Thomas Petazzoni , linux-s390@vger.kernel.org, linux-ia64@vger.kernel.org, Tony Luck , Russell King , Jason Cooper , Fenghua Yu , linux-mips@linux-mips.org, x86@kernel.org, Heiko Carstens , Chris Metcalf , sparclinux@vger.kernel.org, Ingo Molnar , Paul Mackerras , "H. Peter Anvin" , Martin Schwidefsky , linux390@de.ibm.com, Thomas Gleixner , linuxppc-dev@lists.ozlabs.org, "David S. Miller" List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, Nov 20, 2013 at 10:50:43AM +0800, Richard Zhu wrote: Looking good, Acked-by: Ralf Baechle Nevertheless I'd again like to express that I'm not that fond of of the increasing number of weak functions in the kernel. In the old days things were such that when an a platform didn't provice a platform hook or enable a default hook function, one would get a build error - an unmistakable sign to the maintainer that something needs attention. Weak functions mean default functions may result in subtly incorrect operation. Been there, got bitten. Ralf