All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org,
	linux-rt-users <linux-rt-users@vger.kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Carsten Emde <C.Emde@osadl.org>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	John Kacur <jkacur@redhat.com>,
	Ivo Sieben <meltedpianoman@gmail.com>,
	Thomas Pfaff <tpfaff@pcs.com>
Subject: [PATCH RT 1/5] genirq: Set the irq thread policy without checking CAP_SYS_NICE
Date: Thu, 21 Nov 2013 13:43:58 -0500	[thread overview]
Message-ID: <20131121184629.497182845@goodmis.org> (raw)
In-Reply-To: 20131121184357.391591135@goodmis.org

[-- Attachment #1: 0001-genirq-Set-the-irq-thread-policy-without-checking-CA.patch --]
[-- Type: text/plain, Size: 1500 bytes --]

3.2.52-rt74-rc1 stable review patch.
If anyone has any objections, please let me know.

------------------

From: Thomas Pfaff <tpfaff@pcs.com>

In commit ee23871389 ("genirq: Set irq thread to RT priority on
creation") we moved the assigment of the thread's priority from the
thread's function into __setup_irq(). That function may run in user
context for instance if the user opens an UART node and then driver
calls requests in the ->open() callback. That user may not have
CAP_SYS_NICE and so the irq thread won't run with the SCHED_OTHER
policy.

This patch uses sched_setscheduler_nocheck() so we omit the CAP_SYS_NICE
check which is otherwise required for the SCHED_OTHER policy.

Cc: Ivo Sieben <meltedpianoman@gmail.com>
Cc: stable@vger.kernel.org
Cc: stable-rt@vger.kernel.org
Signed-off-by: Thomas Pfaff <tpfaff@pcs.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
[bigeasy: rewrite the changelog]
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
 kernel/irq/manage.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
index 88a4ff5..5b51ba7 100644
--- a/kernel/irq/manage.c
+++ b/kernel/irq/manage.c
@@ -1041,7 +1041,7 @@ __setup_irq(unsigned int irq, struct irq_desc *desc, struct irqaction *new)
 			goto out_mput;
 		}
 
-		sched_setscheduler(t, SCHED_FIFO, &param);
+		sched_setscheduler_nocheck(t, SCHED_FIFO, &param);
 
 		/*
 		 * We keep the reference to the task struct even if
-- 
1.8.4.rc3

  reply	other threads:[~2013-11-21 18:43 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-21 18:43 [PATCH RT 0/5] [ANNOUNCE] 3.2.52-rt74-rc1 Steven Rostedt
2013-11-21 18:43 ` Steven Rostedt [this message]
2013-11-21 18:43 ` [PATCH RT 2/5] hwlat-detector: Dont ignore threshold module parameter Steven Rostedt
2013-11-21 18:44 ` [PATCH RT 3/5] mm/memcontrol: Dont call schedule_work_on in preemption disabled context Steven Rostedt
2013-11-21 18:44 ` [PATCH RT 4/5] drm: remove preempt_disable() from drm_calc_vbltimestamp_from_scanoutpos() Steven Rostedt
2013-11-21 18:44 ` [PATCH RT 5/5] Linux 3.2.52-rt74-rc1 Steven Rostedt
  -- strict thread matches above, loose matches on Subject: below --
2013-11-21 18:41 [PATCH RT 0/5] Linux 3.4.69-rt86-rc1 Steven Rostedt
2013-11-21 18:42 ` [PATCH RT 1/5] genirq: Set the irq thread policy without checking CAP_SYS_NICE Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131121184629.497182845@goodmis.org \
    --to=rostedt@goodmis.org \
    --cc=C.Emde@osadl.org \
    --cc=bigeasy@linutronix.de \
    --cc=jkacur@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=meltedpianoman@gmail.com \
    --cc=tglx@linutronix.de \
    --cc=tpfaff@pcs.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.