From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33339) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vjrnh-0001k9-I0 for qemu-devel@nongnu.org; Fri, 22 Nov 2013 09:33:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vjrnb-0001xX-Aj for qemu-devel@nongnu.org; Fri, 22 Nov 2013 09:33:41 -0500 Received: from mx1.redhat.com ([209.132.183.28]:35419) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vjrnb-0001xO-3G for qemu-devel@nongnu.org; Fri, 22 Nov 2013 09:33:35 -0500 Date: Fri, 22 Nov 2013 09:33:28 -0500 From: Luiz Capitulino Message-ID: <20131122093328.397c376f@redhat.com> In-Reply-To: <528EBB80.2010601@linux.vnet.ibm.com> References: <1384307094-5836-1-git-send-email-xiawenc@linux.vnet.ibm.com> <528EBB80.2010601@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH RFC 0/3] add direct support of event in qapi schema List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia Cc: kwolf@redhat.com, armbru@redhat.com, mdroth@linux.vnet.ibm.com, qemu-devel@nongnu.org, pbonzini@redhat.com On Fri, 22 Nov 2013 10:03:44 +0800 Wenchao Xia wrote: > =E4=BA=8E 2013/11/13 9:44, Wenchao Xia =E5=86=99=E9=81=93: > > This series add support for tag/keyword 'event' in qapi-schema. > > The implemention doesn't generate a struture and visit function > > in the background for every event, so it doesn't support nested > > structure in the define to avoid trouble. > >=20 > > It is on top of series: > > http://lists.nongnu.org/archive/html/qemu-devel/2013-11/msg01574.html > >=20 > > Wenchao Xia (3): > > 1 os-posix: include sys/time.h > > 2 qapi script: add support of event > > 3 tests: add test cases for qapi event support > >=20 > > Makefile | 9 +- > > Makefile.objs | 2 +- > > include/sysemu/os-posix.h | 2 + > > qapi/Makefile.objs | 1 + > > scripts/qapi-event.py | 355 ++++++++++++++++++++++= +++++++++ > > tests/Makefile | 14 +- > > tests/qapi-schema/qapi-schema-test.json | 12 + > > tests/qapi-schema/qapi-schema-test.out | 10 +- > > tests/test-qmp-event.c | 250 ++++++++++++++++++++++ > > 9 files changed, 646 insertions(+), 9 deletions(-) > > create mode 100644 scripts/qapi-event.py > > create mode 100644 tests/test-qmp-event.c > >=20 > Luiz, do you think this series is in the right direction? Sorry, but I haven't reviewed it yet. Will do it next week.