From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] i915, debugfs: Fix uninitialized warning Date: Fri, 22 Nov 2013 17:09:59 +0200 Message-ID: <20131122150959.GD10036@intel.com> References: <1385048986-14478-1-git-send-email-bp@alien8.de> <20131121162535.GK26009@pd.tnic> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <20131121162535.GK26009@pd.tnic> Sender: linux-kernel-owner@vger.kernel.org To: Borislav Petkov Cc: Richard Weinberger , Daniel Vetter , intel-gfx@lists.freedesktop.org, LKML , DRI mailing list , Borislav Petkov List-Id: dri-devel@lists.freedesktop.org On Thu, Nov 21, 2013 at 05:25:35PM +0100, Borislav Petkov wrote: > On Thu, Nov 21, 2013 at 05:10:30PM +0100, Richard Weinberger wrote: > > > diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/dr= m/i915/i915_debugfs.c > > > index 6ed45a984230..1191aa47adc9 100644 > > > --- a/drivers/gpu/drm/i915/i915_debugfs.c > > > +++ b/drivers/gpu/drm/i915/i915_debugfs.c > > > @@ -2347,7 +2347,7 @@ static int pipe_crc_set_source(struct drm_d= evice *dev, enum pipe pipe, > > > { > > > struct drm_i915_private *dev_priv =3D dev->dev_private; > > > struct intel_pipe_crc *pipe_crc =3D &dev_priv->pipe_crc[p= ipe]; > > > - u32 val; > > > + u32 val =3D 0; /* shut up gcc */ > >=20 > > Wouldn't it be better to use uninitialized_var() here? >=20 > I remember Linus' rant about this macro so that's why I don't use it > anymore. >=20 > In this specific case, it doesn't matter whichever we do so I'll let = the > maintainer make a wish :) IIRC this warning was there for me too on gcc 4.6, but it disappeared on gcc 4.7, which is why I decided not to send a patch for it. --=20 Ville Syrj=E4l=E4 Intel OTC