Re: [Qemu-devel] [PATCH v9 10/11] target-arm: Provide '-cpu host' when running KVM

[Christoffer Dall <christoffer.dall@linaro.org>]

On Fri, Nov 22, 2013 at 06:50:47PM +0000, Peter Maydell wrote:
> On 22 November 2013 18:25, Christoffer Dall <christoffer.dall@linaro.org> wrote:
> > On Fri, Nov 22, 2013 at 05:17:17PM +0000, Peter Maydell wrote:
> >> +bool kvm_arm_create_scratch_host_vcpu(const uint32_t *cpus_to_try,
> >> +                                      int *fdarray,
> >> +                                      struct kvm_vcpu_init *init);
> >
> > why do we need to export this at all?
> 
> For 64 bit KVM support the 32 bit code moves into kvm32.c
> and then we have two users of this function, one in
> kvm32.c and one in kvm64.c. It seemed easiest to just
> make the function public with the proper doc comment
> from the start, rather than starting it private and
> then having a patch which makes it public.
> 
Yes, that does make sense.

Thanks.