Re: [PATCH 1/2] remove recursive call to migrate_disable in read_lock_bh

[Nicholas Mc Guire <der.herr@hofr.at>]

On Fri, 22 Nov 2013, Sebastian Andrzej Siewior wrote:

> * Nicholas Mc Guire | 2013-11-20 11:21:07 [+0100]:
> 
> >diff --git a/include/linux/rwlock_rt.h b/include/linux/rwlock_rt.h
> >index 853ee36..87f5a1d 100644
> >--- a/include/linux/rwlock_rt.h
> >+++ b/include/linux/rwlock_rt.h
> >@@ -53,7 +53,6 @@ extern void __rt_rwlock_init(rwlock_t *rwlock, char *name, struct lock_class_key
> > #define read_lock_bh(lock)				\
> > 	do {						\
> > 		local_bh_disable();			\
> >-		migrate_disable();			\
> > 		rt_read_lock(lock);			\
> > 	} while (0)
> > 
> 
> local_bh_disable() does only.
> | add_preempt_count()
> 
> Where is that second migrate_disable() comming from?
>
hmmm. am I looking at the wrong code path ?

kernel/softirq.c
void local_bh_disable(void)
{
        migrate_disable();
        current->softirq_nestcnt++;
}

confused... will check again.
hofrat