From mboxrd@z Thu Jan 1 00:00:00 1970 From: tony@atomide.com (Tony Lindgren) Date: Fri, 22 Nov 2013 17:07:13 -0800 Subject: [PATCH] of/platform: Fix no irq domain found errors when populating interrupts In-Reply-To: <20131123004334.GJ10023@atomide.com> References: <20131123004334.GJ10023@atomide.com> Message-ID: <20131123010712.GM10023@atomide.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org * Tony Lindgren [131122 16:44]: > @@ -168,7 +218,13 @@ struct platform_device *of_device_alloc(struct device_node *np, > rc = of_address_to_resource(np, i, res); > WARN_ON(rc); > } > - WARN_ON(of_irq_to_resource_table(np, res, num_irq) != num_irq); > + > + /* See of_device_resource_notify for populating interrupts */ > + for (i = 0; i < num_irq; i++, res++) { > + res->flags = IORESOURCE_IRQ; > + res->start = -EPROBE_DEFER; > + res->end = -EPROBE_DEFER; > + } Hmm actually we want to use some other value here as res->start is not an int. Maybe some kind of hwirq_max + EPROBE_DEFER. Tony From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH] of/platform: Fix no irq domain found errors when populating interrupts Date: Fri, 22 Nov 2013 17:07:13 -0800 Message-ID: <20131123010712.GM10023@atomide.com> References: <20131123004334.GJ10023@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20131123004334.GJ10023-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Grant Likely , Rob Herring Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org * Tony Lindgren [131122 16:44]: > @@ -168,7 +218,13 @@ struct platform_device *of_device_alloc(struct device_node *np, > rc = of_address_to_resource(np, i, res); > WARN_ON(rc); > } > - WARN_ON(of_irq_to_resource_table(np, res, num_irq) != num_irq); > + > + /* See of_device_resource_notify for populating interrupts */ > + for (i = 0; i < num_irq; i++, res++) { > + res->flags = IORESOURCE_IRQ; > + res->start = -EPROBE_DEFER; > + res->end = -EPROBE_DEFER; > + } Hmm actually we want to use some other value here as res->start is not an int. Maybe some kind of hwirq_max + EPROBE_DEFER. Tony -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755933Ab3KWBHS (ORCPT ); Fri, 22 Nov 2013 20:07:18 -0500 Received: from mho-02-ewr.mailhop.org ([204.13.248.72]:51056 "EHLO mho-02-ewr.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755634Ab3KWBHQ (ORCPT ); Fri, 22 Nov 2013 20:07:16 -0500 X-Mail-Handler: Dyn Standard SMTP by Dyn X-Originating-IP: 50.131.214.131 X-Report-Abuse-To: abuse@dyndns.com (see http://www.dyndns.com/services/sendlabs/outbound_abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX1/grwIuKmmcOCqfg+RonSx8 Date: Fri, 22 Nov 2013 17:07:13 -0800 From: Tony Lindgren To: Grant Likely , Rob Herring Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] of/platform: Fix no irq domain found errors when populating interrupts Message-ID: <20131123010712.GM10023@atomide.com> References: <20131123004334.GJ10023@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20131123004334.GJ10023@atomide.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Tony Lindgren [131122 16:44]: > @@ -168,7 +218,13 @@ struct platform_device *of_device_alloc(struct device_node *np, > rc = of_address_to_resource(np, i, res); > WARN_ON(rc); > } > - WARN_ON(of_irq_to_resource_table(np, res, num_irq) != num_irq); > + > + /* See of_device_resource_notify for populating interrupts */ > + for (i = 0; i < num_irq; i++, res++) { > + res->flags = IORESOURCE_IRQ; > + res->start = -EPROBE_DEFER; > + res->end = -EPROBE_DEFER; > + } Hmm actually we want to use some other value here as res->start is not an int. Maybe some kind of hwirq_max + EPROBE_DEFER. Tony