From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from moutng.kundenserver.de ([212.227.126.171]:64869 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750943Ab3KWSCp (ORCPT ); Sat, 23 Nov 2013 13:02:45 -0500 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Subject: Re: Fwd: [PATCH 6/8] watchdog: davinci: reuse driver for keystone arch Date: Sat, 23 Nov 2013 19:02:02 +0100 Cc: "ivan.khoronzhuk" , Santosh Shilimkar , wim@iguana.be, nsekhar@ti.com, linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org, mark.rutland@arm.com, pawel.moll@arm.com, swarren@wwwdotorg.org, ijc+devicetree@hellion.org.uk, galak@kernel.crashing.org, rob.herring@calxeda.com, linux-kernel@vger.kernel.org, grant.likely@linaro.org References: <1383680783-12114-7-git-send-email-ivan.khoronzhuk@ti.com> <527A28DE.4030906@ti.com> In-Reply-To: <527A28DE.4030906@ti.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201311231902.02807.arnd@arndb.de> Sender: linux-watchdog-owner@vger.kernel.org List-Id: linux-watchdog@vger.kernel.org On Wednesday 06 November 2013, ivan.khoronzhuk wrote: > @@ -1,13 +1,20 @@ > -DaVinci Watchdog Timer (WDT) Controller > +Texas Instruments DaVinci/Keystone Watchdog Timer (WDT) Controller > > Required properties: > -- compatible : Should be "ti,davinci-wdt" > + > +- compatible: "ti,davinci-wdt" > + "ti,keystone-wdt" > + > - reg : Should contain WDT registers location and length > ... > @@ -229,6 +229,7 @@ static int davinci_wdt_remove(struct platform_device *pdev) > > static const struct of_device_id davinci_wdt_of_match[] = { > { .compatible = "ti,davinci-wdt", }, > + { .compatible = "ti,keystone-wdt", }, > {}, > }; > MODULE_DEVICE_TABLE(of, davinci_wdt_of_match); You should clarify the compatible list here: It seems that the devices are fully compatible, so the driver should only need to check for "ti,davinci-wdt" as the compatible string, while the dtb files should list both "ti,davinci-wdt" and "ti,keystone-wdt" for keystone, but only the davinci string for davinci. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Sat, 23 Nov 2013 19:02:02 +0100 Subject: Fwd: [PATCH 6/8] watchdog: davinci: reuse driver for keystone arch In-Reply-To: <527A28DE.4030906@ti.com> References: <1383680783-12114-7-git-send-email-ivan.khoronzhuk@ti.com> <527A28DE.4030906@ti.com> Message-ID: <201311231902.02807.arnd@arndb.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wednesday 06 November 2013, ivan.khoronzhuk wrote: > @@ -1,13 +1,20 @@ > -DaVinci Watchdog Timer (WDT) Controller > +Texas Instruments DaVinci/Keystone Watchdog Timer (WDT) Controller > > Required properties: > -- compatible : Should be "ti,davinci-wdt" > + > +- compatible: "ti,davinci-wdt" > + "ti,keystone-wdt" > + > - reg : Should contain WDT registers location and length > ... > @@ -229,6 +229,7 @@ static int davinci_wdt_remove(struct platform_device *pdev) > > static const struct of_device_id davinci_wdt_of_match[] = { > { .compatible = "ti,davinci-wdt", }, > + { .compatible = "ti,keystone-wdt", }, > {}, > }; > MODULE_DEVICE_TABLE(of, davinci_wdt_of_match); You should clarify the compatible list here: It seems that the devices are fully compatible, so the driver should only need to check for "ti,davinci-wdt" as the compatible string, while the dtb files should list both "ti,davinci-wdt" and "ti,keystone-wdt" for keystone, but only the davinci string for davinci. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: Fwd: [PATCH 6/8] watchdog: davinci: reuse driver for keystone arch Date: Sat, 23 Nov 2013 19:02:02 +0100 Message-ID: <201311231902.02807.arnd@arndb.de> References: <1383680783-12114-7-git-send-email-ivan.khoronzhuk@ti.com> <527A28DE.4030906@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <527A28DE.4030906@ti.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: linux-arm-kernel@lists.infradead.org Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, linux-watchdog@vger.kernel.org, pawel.moll@arm.com, swarren@wwwdotorg.org, ijc+devicetree@hellion.org.uk, nsekhar@ti.com, galak@kernel.crashing.org, rob.herring@calxeda.com, linux-kernel@vger.kernel.org, wim@iguana.be, Santosh Shilimkar , grant.likely@linaro.org, "ivan.khoronzhuk" List-Id: devicetree@vger.kernel.org On Wednesday 06 November 2013, ivan.khoronzhuk wrote: > @@ -1,13 +1,20 @@ > -DaVinci Watchdog Timer (WDT) Controller > +Texas Instruments DaVinci/Keystone Watchdog Timer (WDT) Controller > > Required properties: > -- compatible : Should be "ti,davinci-wdt" > + > +- compatible: "ti,davinci-wdt" > + "ti,keystone-wdt" > + > - reg : Should contain WDT registers location and length > ... > @@ -229,6 +229,7 @@ static int davinci_wdt_remove(struct platform_device *pdev) > > static const struct of_device_id davinci_wdt_of_match[] = { > { .compatible = "ti,davinci-wdt", }, > + { .compatible = "ti,keystone-wdt", }, > {}, > }; > MODULE_DEVICE_TABLE(of, davinci_wdt_of_match); You should clarify the compatible list here: It seems that the devices are fully compatible, so the driver should only need to check for "ti,davinci-wdt" as the compatible string, while the dtb files should list both "ti,davinci-wdt" and "ti,keystone-wdt" for keystone, but only the davinci string for davinci. Arnd