From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko =?iso-8859-1?q?St=FCbner?= Subject: Re: IRQF_RESUME_EARLY and errors in dpm_suspend_noirq Date: Sat, 23 Nov 2013 22:25:48 +0100 Message-ID: <201311232225.48973.heiko@sntech.de> References: <201311201020.08158.heiko@sntech.de> <528C86C2.1070206@nvidia.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT Return-path: Received: from gloria.sntech.de ([95.129.55.99]:39484 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752018Ab3KWV0O convert rfc822-to-8bit (ORCPT ); Sat, 23 Nov 2013 16:26:14 -0500 In-Reply-To: <528C86C2.1070206@nvidia.com> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Laxman Dewangan Cc: Ian Campbell , "Rafael J. Wysocki" , Thomas Gleixner , Len Brown , Greg Kroah-Hartman , Pavel Machek , "linux-kernel@vger.kernel.org" , "linux-pm@vger.kernel.org" Hi Laxman, Am Mittwoch, 20. November 2013, 10:54:10 schrieb Laxman Dewangan: > > I may be blind, but where get the early-irqs resumed in the error > > path of dpm_suspend_noirq? > > > > When a suspend_noirq callback returns an error, dpm_resume_noirq gets > > called, which only calls resume_device_irqs while the > > suspend_device_irqs call in dpm_suspend_noirq suspends all irqs. So it > > does not seem that the early-irqs get resumed at all in this case. > > I also faced same issue in our suspend failure path and posted fix > sometime ago as > https://lkml.org/lkml/2013/8/13/373 > > It is still under review. >>From the thread on lkml.org it looks like it got no reaction at all - maybe was just overlooked. So maybe it would be good to re-send it. As it is not visible on lkml.org, did you also include stable@kernel.org, as the issue started in 2011? > You can try this patch if it resolve the issue. Your patch looks a lot more sophisticated than my current band-aid fix :-) by using the fact that irqs won't get resumed twice on their own. So if you repost your patch you could add an Acked-by: Heiko Stuebner Heiko