From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53996) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VkY5d-0003dl-Nr for qemu-devel@nongnu.org; Sun, 24 Nov 2013 06:43:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VkY5X-0007s0-Pe for qemu-devel@nongnu.org; Sun, 24 Nov 2013 06:43:01 -0500 Received: from mx1.redhat.com ([209.132.183.28]:49303) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VkY5X-0007rt-Hb for qemu-devel@nongnu.org; Sun, 24 Nov 2013 06:42:55 -0500 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rAOBgsnr020308 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sun, 24 Nov 2013 06:42:55 -0500 Date: Sun, 24 Nov 2013 13:46:11 +0200 From: "Michael S. Tsirkin" Message-ID: <20131124114611.GC8776@redhat.com> References: <1385062405-3800-1-git-send-email-marcel.a@redhat.com> <20131124113327.GC7528@redhat.com> <1385293029.2177.16.camel@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1385293029.2177.16.camel@localhost.localdomain> Subject: Re: [Qemu-devel] [PATCH for-1.7 0/5] acpi unit-test: added tests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Marcel Apfelbaum Cc: qemu-devel@nongnu.org On Sun, Nov 24, 2013 at 01:37:09PM +0200, Marcel Apfelbaum wrote: > On Sun, 2013-11-24 at 13:33 +0200, Michael S. Tsirkin wrote: > > On Thu, Nov 21, 2013 at 09:33:20PM +0200, Marcel Apfelbaum wrote: > > > Added 2 tests: > > > 1. Basic check of FACS table (missed on prev submission) > > > 2. Compare DSDT and SSDT tables against expected values > > > > > > Test 2: > > > - runs only if iasl is installed on the host machine. > > > - the test plan: > > > 1. Dumps the ACPI tables as AML on the disk. > > > 2. Runs iasl to disassembly the tables into ASL files. > > > 3. Compares them with expected offline ASL files. > > > > > > - the test runs for both default machine and q35. > > > - in case the test fails, it can be easily tweaked to > > > show the differences between the ASL files and > > > understand the issue. > > > > That's very useful, thanks. > > But why do you want to put this in 1.7? > Because the generation of the ACPI tables > was moved to qemu in 1.7 and the unit-tests can be > viewed as feature validation. > > I have nothing against moving it to 1.8, its up to you, > Thanks, > Marcel I see. I do worry about adding non bugfix patches now but maybe tests are an exception? What do others think? > > > > > Patches: > > > 1/5 - test 1 > > > 2/5 - some infrastructure improvements > > > 3/5 - expected asl files for test 2 > > > 4/5 - creates links for the expected files > > > if the build directory is not current > > > 5/5 - test 2 > > > > > > Marcel Apfelbaum (5): > > > acpi unit-test: load and check facs table > > > acpi unit-test: adjust the test data structure for better handling > > > acpi unit-test: add test files > > > configure: added acpi unit-test files > > > acpi unit-test: compare DSDT and SSDT tables against expected values > > > > > > configure | 4 + > > > tests/acpi-test-data/pc/APIC.dsl | 103 ++ > > > tests/acpi-test-data/pc/DSDT.dsl | 1870 ++++++++++++++++++++++ > > > tests/acpi-test-data/pc/FACP.dsl | 99 ++ > > > tests/acpi-test-data/pc/FACS.dsl | 32 + > > > tests/acpi-test-data/pc/HPET.dsl | 43 + > > > tests/acpi-test-data/pc/SSDT.dsl | 634 ++++++++ > > > tests/acpi-test-data/q35/APIC.dsl | 103 ++ > > > tests/acpi-test-data/q35/DSDT.dsl | 3197 +++++++++++++++++++++++++++++++++++++ > > > tests/acpi-test-data/q35/FACP.dsl | 99 ++ > > > tests/acpi-test-data/q35/FACS.dsl | 32 + > > > tests/acpi-test-data/q35/HPET.dsl | 43 + > > > tests/acpi-test-data/q35/MCFG.dsl | 36 + > > > tests/acpi-test-data/q35/SSDT.dsl | 665 ++++++++ > > > tests/acpi-test.c | 282 +++- > > > 15 files changed, 7210 insertions(+), 32 deletions(-) > > > create mode 100644 tests/acpi-test-data/pc/APIC.dsl > > > create mode 100644 tests/acpi-test-data/pc/DSDT.dsl > > > create mode 100644 tests/acpi-test-data/pc/FACP.dsl > > > create mode 100644 tests/acpi-test-data/pc/FACS.dsl > > > create mode 100644 tests/acpi-test-data/pc/HPET.dsl > > > create mode 100644 tests/acpi-test-data/pc/SSDT.dsl > > > create mode 100644 tests/acpi-test-data/q35/APIC.dsl > > > create mode 100644 tests/acpi-test-data/q35/DSDT.dsl > > > create mode 100644 tests/acpi-test-data/q35/FACP.dsl > > > create mode 100644 tests/acpi-test-data/q35/FACS.dsl > > > create mode 100644 tests/acpi-test-data/q35/HPET.dsl > > > create mode 100644 tests/acpi-test-data/q35/MCFG.dsl > > > create mode 100644 tests/acpi-test-data/q35/SSDT.dsl > > > > > > -- > > > 1.8.3.1 > > > > >