All of lore.kernel.org
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@alien8.de>
To: Francis Moreau <francis.moro@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Jingoo Han <jg1.han@samsung.com>,
	"'Wei WANG'" <wei_wang@realsil.com.cn>,
	"'LKML'" <linux-kernel@vger.kernel.org>,
	"'Samuel Ortiz'" <sameo@linux.intel.com>,
	"'Chris Ball'" <cjb@laptop.org>
Subject: Re: 3.12: kernel panic when resuming from suspend to RAM (x86_64)
Date: Sun, 24 Nov 2013 14:31:10 +0100	[thread overview]
Message-ID: <20131124133110.GD4208@pd.tnic> (raw)
In-Reply-To: <5291C948.1080305@gmail.com>

On Sun, Nov 24, 2013 at 10:39:20AM +0100, Francis Moreau wrote:
> This looks like it was a good idea.
> 
> The kernel now outputs the following traces after resuming.
> 
> [   26.973928] WARNING: CPU: 0 PID: 4 at lib/debugobjects.c:260
> debug_print_object+0x83/0xa0()
> [   26.973932] ODEBUG: free active (active state 0) object type:
> timer_list hint: delayed_work_timer_fn+0x0/0x20

Just a stab in the dark, does the below fix it?

--
diff --git a/drivers/mfd/rtsx_pcr.c b/drivers/mfd/rtsx_pcr.c
index 11e20afbdcac..e65a12dd6e20 100644
--- a/drivers/mfd/rtsx_pcr.c
+++ b/drivers/mfd/rtsx_pcr.c
@@ -1228,8 +1228,8 @@ static void rtsx_pci_remove(struct pci_dev *pcidev)
 
 	pcr->remove_pci = true;
 
-	cancel_delayed_work(&pcr->carddet_work);
-	cancel_delayed_work(&pcr->idle_work);
+	cancel_delayed_work_sync(&pcr->carddet_work);
+	cancel_delayed_work_sync(&pcr->idle_work);
 
 	mfd_remove_devices(&pcidev->dev);
 

-- 
Regards/Gruss,
    Boris.

Sent from a fat crate under my desk. Formatting is fine.
--

  reply	other threads:[~2013-11-24 13:31 UTC|newest]

Thread overview: 63+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-17  9:42 3.12: kernel panic when resuming from suspend to RAM (x86_64) Francis Moreau
2013-11-17 13:25 ` Borislav Petkov
2013-11-17 15:50   ` Francis Moreau
2013-11-17 16:01     ` Borislav Petkov
2013-11-17 18:02       ` Francis Moreau
2013-11-17 19:53         ` Borislav Petkov
2013-11-17 20:49           ` Francis Moreau
2013-11-17 22:06             ` Borislav Petkov
2013-11-17 22:34               ` Rafael J. Wysocki
2013-11-17 22:46                 ` Borislav Petkov
2013-11-18 12:21                   ` Francis Moreau
2013-11-18 12:20                 ` Francis Moreau
2013-11-18  0:33               ` Kevin Easton
2013-11-18  1:04                 ` Borislav Petkov
2013-11-18  2:43                   ` Kevin Easton
2013-11-18 12:19               ` Francis Moreau
2013-11-18 13:32                 ` Borislav Petkov
2013-11-19 10:01                   ` Francis Moreau
2013-11-19 10:15                     ` Borislav Petkov
2013-11-20  9:45                       ` Francis Moreau
2013-11-20 11:15                         ` Borislav Petkov
2013-11-21  8:22                           ` Francis Moreau
2013-11-21 10:12                             ` Borislav Petkov
2013-11-21 11:17                               ` Jingoo Han
2013-11-21 13:07                                 ` Francis Moreau
2013-11-22  7:43                                 ` Francis Moreau
2013-11-22  9:57                                   ` Francis Moreau
2013-11-22 12:54                                     ` Rafael J. Wysocki
2013-11-22 21:36                                       ` Francis Moreau
2013-11-22 22:08                                         ` Rafael J. Wysocki
2013-11-22 22:27                                           ` Thomas Gleixner
2013-11-24  9:39                                             ` Francis Moreau
2013-11-24 13:31                                               ` Borislav Petkov [this message]
2013-11-24 21:06                                               ` Rafael J. Wysocki
2013-11-25  7:42                                                 ` Francis Moreau
2013-11-25 10:47                                                   ` Rafael J. Wysocki
2013-11-29  8:28                                                     ` Francis Moreau
2013-11-29  9:02                                                       ` Thomas Gleixner
2013-11-30 15:07                                                         ` Francis Moreau
2013-11-30 20:17                                                           ` Rafael J. Wysocki
2013-12-01 10:11                                                             ` Francis Moreau
2013-12-01 19:26                                                             ` Francis Moreau
2013-12-02 10:49                                                           ` Thomas Gleixner
2013-12-02 11:20                                                             ` Thomas Gleixner
2013-12-03  8:14                                                               ` Francis Moreau
2013-12-09 19:33                                                                 ` Francis Moreau
2013-12-09 22:27                                                                   ` Samuel Ortiz
2013-12-09 22:17                                                                 ` Samuel Ortiz
2013-12-10  1:39                                                                   ` wwang
2013-12-10  1:56                                                                     ` micky
2013-12-10  8:29                                                                       ` Samuel Ortiz
2014-01-10  7:26                                                                         ` Francis Moreau
2014-01-10  9:16                                                                           ` micky
2014-01-10  9:52                                                                           ` Samuel Ortiz
2014-01-10 10:07                                                                             ` Francis Moreau
2013-12-10 10:50                                                                       ` Francis Moreau
2013-12-17  8:03                                                                       ` Francis Moreau
2013-12-18  4:05                                                                         ` micky
2013-12-18  8:12                                                                           ` Francis Moreau
2013-12-20  1:30                                                                             ` micky
2013-12-20  2:28                                                                               ` Jingoo Han
2013-12-10 10:49                                                                   ` Francis Moreau
2013-11-24  9:42                                           ` Francis Moreau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131124133110.GD4208@pd.tnic \
    --to=bp@alien8.de \
    --cc=cjb@laptop.org \
    --cc=francis.moro@gmail.com \
    --cc=jg1.han@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rjw@rjwysocki.net \
    --cc=sameo@linux.intel.com \
    --cc=tglx@linutronix.de \
    --cc=wei_wang@realsil.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.