From: Ezequiel Garcia <ezequiel.garcia-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] spi: spi-gpio: Use 'cansleep' variants to access GPIO
Date: Sun, 24 Nov 2013 12:56:29 -0300 [thread overview]
Message-ID: <20131124155628.GA3417@localhost> (raw)
In-Reply-To: <20131124141255.GZ14725-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
On Sun, Nov 24, 2013 at 02:12:55PM +0000, Mark Brown wrote:
> On Sun, Nov 24, 2013 at 09:37:01AM -0300, Ezequiel Garcia wrote:
> > The GPIO chip in use could be of any kind, and therefore might sleep
> > when accesing the GPIO lines. Take account of this by using cansleep
> > instead, which is the most generic case.
>
> Applied, thanks.
Mark:
I'm just wondering -as I don't have much experience with gpiolib-
is this replacement the Right Thing To Do?
It seemed to me that the xxx_cansleep variant just adds a check
and a might_sleep, so this change won't hurt the general case.
Is this correct?
--
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-11-24 15:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-24 12:37 [PATCH] spi: spi-gpio: Use 'cansleep' variants to access GPIO Ezequiel Garcia
[not found] ` <1385296621-23638-1-git-send-email-ezequiel.garcia-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2013-11-24 14:12 ` Mark Brown
[not found] ` <20131124141255.GZ14725-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2013-11-24 15:56 ` Ezequiel Garcia [this message]
2013-11-25 10:19 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131124155628.GA3417@localhost \
--to=ezequiel.garcia-wi1+55scjutkeb57/3fjtnbpr1lh4cv8@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.