From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: deepak.s@intel.com
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/3] drm/i915/vlv: Valleyview support for forcewake Individual power wells.
Date: Mon, 25 Nov 2013 08:36:59 -0800 [thread overview]
Message-ID: <20131125083659.623381d2@jbarnes-desktop> (raw)
In-Reply-To: <1385198744-9333-3-git-send-email-deepak.s@intel.com>
On Sat, 23 Nov 2013 14:55:43 +0530
deepak.s@intel.com wrote:
> diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
> index 9292c9e..04d46b2 100644
> --- a/drivers/gpu/drm/i915/i915_reg.h
> +++ b/drivers/gpu/drm/i915/i915_reg.h
> @@ -4840,8 +4840,8 @@
> #define EDP_LINK_TRAIN_VOL_EMP_MASK_IVB (0x3f<<22)
>
> #define FORCEWAKE 0xA18C
> -#define FORCEWAKE_VLV 0x1300b0
> -#define FORCEWAKE_ACK_VLV 0x1300b4
> +#define FORCEWAKE_VLV 0x1300b0
> +#define FORCEWAKE_ACK_VLV 0x1300b4
> #define FORCEWAKE_MEDIA_VLV 0x1300b8
> #define FORCEWAKE_ACK_MEDIA_VLV 0x1300bc
> #define FORCEWAKE_ACK_HSW 0x130044
Another spurious hunk, but again maybe Daniel can drop it.
I'd have structured the force wake callbacks a little differently
(still used the vfunc then split the routines into separate _locked
variants for each of render and media), but that's just cosmetic. So:
Reviewed-by: Jesse Barnes <jbarnes@virtuousgeek.org>
--
Jesse Barnes, Intel Open Source Technology Center
next prev parent reply other threads:[~2013-11-25 16:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-23 9:25 [PATCH 0/3] drm/i915: Split VLV forcewake routines deepak.s
2013-11-23 9:25 ` [PATCH 1/3] drm/i915: Add power well arguments to force wake routines deepak.s
2013-11-25 16:29 ` Jesse Barnes
2013-11-23 9:25 ` [PATCH 2/3] drm/i915/vlv: Valleyview support for forcewake Individual power wells deepak.s
2013-11-25 14:48 ` Chris Wilson
2013-11-26 10:10 ` S, Deepak
2013-11-25 16:36 ` Jesse Barnes [this message]
2013-11-23 9:25 ` [PATCH 3/3] drm/i915: Enabling DebugFS for valleyview forcewake counts deepak.s
2013-11-25 16:38 ` Jesse Barnes
2013-11-26 10:12 ` S, Deepak
2013-11-27 15:59 ` Daniel Vetter
2013-11-27 16:30 ` S, Deepak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131125083659.623381d2@jbarnes-desktop \
--to=jbarnes@virtuousgeek.org \
--cc=deepak.s@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.