From: Borislav Petkov <bp@alien8.de>
To: Ingo Molnar <mingo@kernel.org>
Cc: "Joe Perches" <joe@perches.com>, "H. Peter Anvin" <hpa@zytor.com>,
"Johannes Löthberg" <johannes@kyriasis.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Ingo Molnar" <mingo@redhat.com>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86: boot: Fix mixed indentation in a20.c
Date: Mon, 25 Nov 2013 12:02:51 +0100 [thread overview]
Message-ID: <20131125110251.GC6782@pd.tnic> (raw)
In-Reply-To: <20131125101807.GA13385@gmail.com>
On Mon, Nov 25, 2013 at 11:18:07AM +0100, Ingo Molnar wrote:
> If a newbie does a meaningful, complete, well done cleanup patch then
> congratulations and any such help is welcome.
>
> If you as a more experienced kernel developer do a cleanup as part of
> some real work then sure, all such cleanups are welcome and they are a
> natural part of development work.
>
> So a standalone cleanup patch to a20.c from _you_ would probably not
> qualify, almost by definition: your first patch was applied 7 years
> ago, you are by far not a newbie anymore, yet you seem to be mostly
> stuck on the 'cleanups and trivialities' level! Sheesh!
>
> My message to the buerocrat Joe Perches is: please leave trivial and
> printk patches to newbies, you need to raise to the next level of
> kernel development already.
>
> FYI, Linux is a meritocracy, not a bureaucracy: creating self-serving
> churn and attention-seeking but unimportant patches is not the way to
> gain kernel development credibility long term, and eventually people
> start protecting against your increasing abuse of the development
> process. IMHO.
... and not only that - sending patches to the kernel shouldn't be about
the *sending* of patches itself but actually about doing some real
improvement to it.
Thanks Ingo for hitting the nail on the head!
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
next prev parent reply other threads:[~2013-11-25 11:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-18 17:50 [PATCH] x86: boot: Fix mixed indentation in a20.c Johannes Löthberg
2013-11-19 2:22 ` H. Peter Anvin
2013-11-19 7:22 ` Ingo Molnar
2013-11-19 10:34 ` Borislav Petkov
2013-11-19 17:48 ` Joe Perches
2013-11-19 18:23 ` Borislav Petkov
2013-11-19 18:24 ` H. Peter Anvin
2013-11-19 18:28 ` Joe Perches
2013-11-19 18:45 ` H. Peter Anvin
2013-11-19 18:59 ` Borislav Petkov
2013-11-25 10:18 ` Ingo Molnar
2013-11-25 11:02 ` Borislav Petkov [this message]
2013-11-26 0:51 ` Joe Perches
2013-11-26 7:43 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131125110251.GC6782@pd.tnic \
--to=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=joe@perches.com \
--cc=johannes@kyriasis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.