From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Mon, 25 Nov 2013 12:17:10 +0100 From: Thierry Reding Subject: Re: [PATCH 1/5] Documentation: dt: Add kona-pwm binding Message-ID: <20131125111709.GJ22043@ulmo.nvidia.com> References: <1384800901-21711-1-git-send-email-tim.kryger@linaro.org> <1384800901-21711-2-git-send-email-tim.kryger@linaro.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="I/5syFLg1Ed7r+1G" Content-Disposition: inline In-Reply-To: <1384800901-21711-2-git-send-email-tim.kryger@linaro.org> List-ID: To: Tim Kryger Cc: Rob Herring , Pawel Moll , Mark Rutland , Stephen Warren , Ian Campbell , Rob Landley , Christian Daudt , Grant Likely , Linux PWM List , Device Tree List , Linux Doc List , Linux Kernel Mailing List , Broadcom Kernel Feedback List , Linux ARM Kernel List , Linaro Patches List --I/5syFLg1Ed7r+1G Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Nov 18, 2013 at 10:54:57AM -0800, Tim Kryger wrote: > Add the binding description for the kona-pwm block found on Broadcom's > mobile SoCs. >=20 > Signed-off-by: Tim Kryger > Reviewed-by: Alex Elder > Reviewed-by: Markus Mayer > --- > .../devicetree/bindings/pwm/bcm-kona-pwm.txt | 24 ++++++++++++++++= ++++++ > 1 file changed, 24 insertions(+) > create mode 100644 Documentation/devicetree/bindings/pwm/bcm-kona-pwm.txt >=20 > diff --git a/Documentation/devicetree/bindings/pwm/bcm-kona-pwm.txt b/Doc= umentation/devicetree/bindings/pwm/bcm-kona-pwm.txt > new file mode 100644 > index 0000000..5c3ea1b > --- /dev/null > +++ b/Documentation/devicetree/bindings/pwm/bcm-kona-pwm.txt > @@ -0,0 +1,24 @@ > +Broadcom's PWM Controller Device Tree bindings This sounds somewhat strange, like Broadcom owns the bindings... perhaps just: Broadcom PWM controller device tree bindings Or for consistency: Broadcom Kona PWM controller device tree bindings since apparently there exist other Broadcom PWM controllers. > +Broadcom's Kona PWM Controller has 6 channels "controller" and end the sentence with a full stop. > + > +Required Properties : > +- compatible: should be "brcm,kona-pwm" > +- reg: physical base address and length of the controller's registers > +- clocks: clock specifier for the kona pwm external clock Please use the correct spelling "PWM" in prose here and elsewhere. Also you should pick one of "kona", "Kona" or "KONA" and stick with it consistently. Might also be useful to mention what Kona is. Doesn't necessarily have to be in the document, but if for nothing else, then just for my curiosity. > +- #pwm-cells: should be 2. The first cell specifies the per-chip index > + of the PWM to use and the second cell is the period in nanoseconds. > + > +Refer to pwm/pwm.txt for generic pwm controller node properties. > + > +Refer to clocks/clock-bindings.txt for generic clock consumer > +properties This sentence should also end with a full stop. Thierry --I/5syFLg1Ed7r+1G Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJSkzG1AAoJEN0jrNd/PrOhFwsP/iF+BvZaHOAS/+kK80G8wCQW tb0Wkdion8CN0ddWxB8kXvC0YFi5ihEDVRfTA9M/v6Grw631SRCP4RI+v87gENuq BHu+dhzzDqCVYUWg0bY6945MlMLXg/CuRt9uXNk09tny91kvwjzAd4BhhHgogPs7 uDKMrFG5BbO/p8FFS9qe3qWjTcX1lYCloJzHI0QaJI9LnV8qmgYMIgmBigiz24Qx N4QWeLwVoUUiAGuyTunm96CLhWqkrXkJIfUMADTNozTDPWnV8NpPxpBlsKueSJSB Akij2Ta5DPEyXqAns8hGW94bmpFHDP86Ym0GxtbXBnW1xX2JcwXHJwIMWgNAc5wh qnkL7Kfx5j0uR7Zy0unjAB9ONmYRlKWkTs7E2R/dmVzo/UptOPKM/KsUyK4veJmX F1E9ktA3Q/Ywv88anjuYyIlnl3dvVipX4am0kbG8ma36ttmbdgPXIPbalweecuYI gx5koFcMfZi0oVFHSd8kzyJDUp7mGzq9Y1OYzjK8gMhnt9tJXiLeRptcmL7A/3qw IsNX9sPa0qBpNB/4T4rn1KtrdElbk1TnvS/et36vYst0gDSD5ydccFWSUU3veU53 y1zF3mrLAGzjFHNjkzkOlqRoYwgeq7d9W0TJ7vRdBdikD/ym6fE6oDsPukGQrWIE yBpnC981/KEeKQTaL6/E =Vy4a -----END PGP SIGNATURE----- --I/5syFLg1Ed7r+1G-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: thierry.reding@gmail.com (Thierry Reding) Date: Mon, 25 Nov 2013 12:17:10 +0100 Subject: [PATCH 1/5] Documentation: dt: Add kona-pwm binding In-Reply-To: <1384800901-21711-2-git-send-email-tim.kryger@linaro.org> References: <1384800901-21711-1-git-send-email-tim.kryger@linaro.org> <1384800901-21711-2-git-send-email-tim.kryger@linaro.org> Message-ID: <20131125111709.GJ22043@ulmo.nvidia.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, Nov 18, 2013 at 10:54:57AM -0800, Tim Kryger wrote: > Add the binding description for the kona-pwm block found on Broadcom's > mobile SoCs. > > Signed-off-by: Tim Kryger > Reviewed-by: Alex Elder > Reviewed-by: Markus Mayer > --- > .../devicetree/bindings/pwm/bcm-kona-pwm.txt | 24 ++++++++++++++++++++++ > 1 file changed, 24 insertions(+) > create mode 100644 Documentation/devicetree/bindings/pwm/bcm-kona-pwm.txt > > diff --git a/Documentation/devicetree/bindings/pwm/bcm-kona-pwm.txt b/Documentation/devicetree/bindings/pwm/bcm-kona-pwm.txt > new file mode 100644 > index 0000000..5c3ea1b > --- /dev/null > +++ b/Documentation/devicetree/bindings/pwm/bcm-kona-pwm.txt > @@ -0,0 +1,24 @@ > +Broadcom's PWM Controller Device Tree bindings This sounds somewhat strange, like Broadcom owns the bindings... perhaps just: Broadcom PWM controller device tree bindings Or for consistency: Broadcom Kona PWM controller device tree bindings since apparently there exist other Broadcom PWM controllers. > +Broadcom's Kona PWM Controller has 6 channels "controller" and end the sentence with a full stop. > + > +Required Properties : > +- compatible: should be "brcm,kona-pwm" > +- reg: physical base address and length of the controller's registers > +- clocks: clock specifier for the kona pwm external clock Please use the correct spelling "PWM" in prose here and elsewhere. Also you should pick one of "kona", "Kona" or "KONA" and stick with it consistently. Might also be useful to mention what Kona is. Doesn't necessarily have to be in the document, but if for nothing else, then just for my curiosity. > +- #pwm-cells: should be 2. The first cell specifies the per-chip index > + of the PWM to use and the second cell is the period in nanoseconds. > + > +Refer to pwm/pwm.txt for generic pwm controller node properties. > + > +Refer to clocks/clock-bindings.txt for generic clock consumer > +properties This sentence should also end with a full stop. Thierry -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: not available URL: