From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41988) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VkzJg-0001dp-DJ for qemu-devel@nongnu.org; Mon, 25 Nov 2013 11:47:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VkzJb-0008Kw-AZ for qemu-devel@nongnu.org; Mon, 25 Nov 2013 11:47:20 -0500 Received: from mx1.redhat.com ([209.132.183.28]:6494) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VkzJb-0008Kk-2V for qemu-devel@nongnu.org; Mon, 25 Nov 2013 11:47:15 -0500 Date: Mon, 25 Nov 2013 11:47:09 -0500 From: Luiz Capitulino Message-ID: <20131125114709.6a7a805d@redhat.com> In-Reply-To: <1384295108-10913-1-git-send-email-xiawenc@linux.vnet.ibm.com> References: <1384295108-10913-1-git-send-email-xiawenc@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH V2 0/8] qapi script: support enum as discriminator and better enum name List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia Cc: mdroth@linux.vnet.ibm.com, kwolf@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com On Wed, 13 Nov 2013 06:25:00 +0800 Wenchao Xia wrote: > This series is respined from RFC series at: > http://lists.nongnu.org/archive/html/qemu-devel/2013-11/msg00363.html > > Patch 1-6 add support for enum as discriminator. > Patch 7 improve enum name generation, now AIOContext->AIO_CONTEXT, X86CPU-> > X86_CPU. > Patch 8 are the test cases. Can you please clarify what is the problem this series is trying to solve, how it does it and provide before/after type of examples? That's what I'd expect from an intro email, but this one has only a reference to an RFC series that has no better info, and some crypt changelog with magic numbers :( Besides, this doesn't apply anymore... > > Changes from RFC: > Mainly address Eric's comments: fix typo, add patch 2 to allow partly mapping > enum value in union, add related test case, remove direct inherit support "_base" > and related test case. > > v2: > General: > 3: use Raise exception instead of sys.error.write in qapi.py. > Address Eric's comments: > 2,3: more check for enum value at compile time. > 8: correspond test case change. > > Wenchao Xia (8): > 1 qapi script: remember enum values > 2 qapi script: add check for duplicated key > 3 qapi script: check correctness of discriminator values in union > 4 qapi script: code move for generate_enum_name() > 5 qapi script: use same function to generate enum string > 6 qapi script: not generate hidden enum type for pre-defined enum discriminator > 7 qapi script: do not add "_" for every capitalized char in enum > 8 tests: add cases for inherited struct and union with discriminator > > include/qapi/qmp/qerror.h | 2 +- > scripts/qapi-types.py | 34 ++++---- > scripts/qapi-visit.py | 55 +++++++++-- > scripts/qapi.py | 84 ++++++++++++++++- > target-i386/cpu.c | 2 +- > tests/qapi-schema/comments.out | 2 +- > tests/qapi-schema/qapi-schema-test.json | 27 ++++++ > tests/qapi-schema/qapi-schema-test.out | 15 +++- > tests/test-qmp-input-visitor.c | 120 +++++++++++++++++++++++++ > tests/test-qmp-output-visitor.c | 149 +++++++++++++++++++++++++++++++ > 10 files changed, 454 insertions(+), 36 deletions(-) >