From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from arroyo.ext.ti.com (arroyo.ext.ti.com [192.94.94.40]) by arago-project.org (Postfix) with ESMTPS id 9CE3752990 for ; Mon, 25 Nov 2013 16:43:55 +0000 (UTC) Received: from dlelxv90.itg.ti.com ([172.17.2.17]) by arroyo.ext.ti.com (8.13.7/8.13.7) with ESMTP id rAPGhsMD010842 for ; Mon, 25 Nov 2013 10:43:54 -0600 Received: from DFLE73.ent.ti.com (dfle73.ent.ti.com [128.247.5.110]) by dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id rAPGhs4l002649 for ; Mon, 25 Nov 2013 10:43:54 -0600 Received: from dlep33.itg.ti.com (157.170.170.75) by DFLE73.ent.ti.com (128.247.5.110) with Microsoft SMTP Server id 14.2.342.3; Mon, 25 Nov 2013 10:43:53 -0600 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by dlep33.itg.ti.com (8.14.3/8.13.8) with ESMTP id rAPGhrJi000431; Mon, 25 Nov 2013 10:43:53 -0600 Date: Mon, 25 Nov 2013 11:43:53 -0500 From: Denys Dmytriyenko To: "Cooper Jr., Franklin" Message-ID: <20131125164353.GK690@edge> References: <1385398442-24668-1-git-send-email-fcooper@ti.com> <1385398442-24668-3-git-send-email-fcooper@ti.com> <20131125162215.GI690@edge> <8F29D6B095ED194EA1980491A5E029710C5C288B@DFLE08.ent.ti.com> MIME-Version: 1.0 In-Reply-To: <8F29D6B095ED194EA1980491A5E029710C5C288B@DFLE08.ent.ti.com> User-Agent: Mutt/1.5.20 (2009-06-14) Cc: "meta-arago@arago-project.org" Subject: Re: [PATCH 3/7] packagegroup-arago-tisdk-qt: Make packagegroup generic X-BeenThere: meta-arago@arago-project.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Arago metadata layer for TI SDKs - OE-Core/Yocto compatible List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Nov 2013 16:43:56 -0000 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline On Mon, Nov 25, 2013 at 11:35:54AM -0500, Cooper Jr., Franklin wrote: > > > > -----Original Message----- > > From: Dmytriyenko, Denys > > Sent: Monday, November 25, 2013 10:22 AM > > To: Cooper Jr., Franklin > > Cc: meta-arago@arago-project.org > > Subject: Re: [meta-arago] [PATCH 3/7] packagegroup-arago-tisdk-qt: Make > > packagegroup generic > > > > On Mon, Nov 25, 2013 at 10:53:58AM -0600, Franklin S. Cooper Jr wrote: > > > * Update packagegroup so it applies to Qt 5 users along with Qt 4 users. > > > * To reflect this change also rename recipe top reflect that its a generic qt > > > packagegroup. > > > > > > Signed-off-by: Franklin S. Cooper Jr > > > --- > > > .../packagegroups/packagegroup-arago-tisdk-qt.bb | 27 > > ++++++++++++++++++++ > > > .../packagegroups/packagegroup-arago-tisdk-qte.bb | 19 -------------- > > > 2 files changed, 27 insertions(+), 19 deletions(-) create mode > > > 100644 > > > meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk- > > > qt.bb delete mode 100644 > > > meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk- > > > qte.bb > > > > > > diff --git > > > a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisd > > > k-qt.bb > > > b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisd > > > k-qt.bb > > > new file mode 100644 > > > index 0000000..c981f9e > > > --- /dev/null > > > +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago- > > > +++ tisdk-qt.bb > > > @@ -0,0 +1,27 @@ > > > +DESCRIPTION = "Task to add Qt embedded related packages" > > > +LICENSE = "MIT" > > > +PR = "r0" > > > + > > > +inherit packagegroup > > > + > > > +PACKAGE_ARCH = "${MACHINE_ARCH}" > > > + > > > +QT4_DEMOS = "\ > > > + qt4-embedded-examples \ > > > + qt4-embedded-demos \ > > > + ${@base_conditional('ARAGO_QT_PROVIDER', 'qt4-embedded-gles', > > > +'quick-playground', '', d)} \ > > > > BTW, should we drop ARAGO_QT_PROVIDER? > [Franklin] Yeah I think we should. But should we drop QT_PROVIDER and use > ARAGO_QT_PROVIDER instead since this is Arago specific? Or were you planning > on pushing that up to meta-qt5? That was my plan and hope... > No matter what choice we make would you want to make this change before this > patchset, after this patchset or after my remaining Qt 5 patches that I have > yet to send? I have few comments for this patchset and I'm realizing that I want to do couple of things here differently. So, if you don't mind holding on this set for a bit longer, let's cleanup and restructure few things before anything else, Ok? > > We now have QT_PROVIDER for qt4 vs qt5 (can possibly extend it to cover qt4- > > gles too) Otherwise, we started using "sgx" in MACHINE_FEATURES to > > determine whether to enable gles or not. > [Franklin] We would still need to check for sgx in MACHINE_FEATURES since we > don't have a concept of qt5-gles. > So, if we unify on that, we can drop Yeah, extending and combining QT_PROVIDER to cover qt4, qt4-gles, qt5, qt5-gles (and hopefully we'll support x11/wayland one day) is probably too much. So, as I was trying to say, let's drop ARAGO_QT_PROVIDER as a way to check for gles and unify on MACHINE_FEATURES containing "sgx". > > ARAGO_QT_PROVIDER to avoid confusion with QT_PROVIDER. > > > > > > > +" > > > + > > > +QT5_DEMOS = "\ > > > + qtwebkit-examples-examples \ > > > +" > > > + > > > +QT_DEMOS = "\ > > > + ${@base_conditional('QT_PROVIDER', 'qt5', '${QT5_DEMOS}', > > '${QT4_DEMOS}', d)} \ > > > + qt-tstat \ > > > +" > > > + > > > +RDEPENDS_${PN} = "\ > > > + ${@base_conditional('QT_PROVIDER', 'qt5', 'packagegroup-arago-qt5', > > 'packagegroup-arago-qte', d)} \ > > > + ${QT_DEMOS} \ > > > +" > > > diff --git > > > a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisd > > > k-qte.bb > > > b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisd > > > k-qte.bb > > > deleted file mode 100644 > > > index 10187a6..0000000 > > > --- > > > a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisd > > > k-qte.bb > > > +++ /dev/null > > > @@ -1,19 +0,0 @@ > > > -DESCRIPTION = "Task to add Qt embedded related packages" > > > -LICENSE = "MIT" > > > -PR = "r4" > > > - > > > -inherit packagegroup > > > - > > > -PACKAGE_ARCH = "${MACHINE_ARCH}" > > > - > > > -QT_DEMOS = "\ > > > - qt4-embedded-examples \ > > > - qt4-embedded-demos \ > > > - qt-tstat \ > > > - ${@base_conditional('ARAGO_QT_PROVIDER', 'qt4-embedded-gles', > > 'quick-playground', '', d)} \ > > > -" > > > - > > > -RDEPENDS_${PN} = "\ > > > - packagegroup-arago-qte \ > > > - ${QT_DEMOS} \ > > > -" > > > -- > > > 1.7.0.4 > > > > > > _______________________________________________ > > > meta-arago mailing list > > > meta-arago@arago-project.org > > > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago