From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Jason Cooper <jason@lakedaemon.net>,
Ezequiel Garcia <ezequiel.garcia@free-electrons.com>,
linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH 1/2] PCI: mvebu - The bridge should obey the MEM and IO command bits
Date: Mon, 25 Nov 2013 18:09:35 +0100 [thread overview]
Message-ID: <20131125180935.37ee3222@skate> (raw)
In-Reply-To: <1383262380-6984-1-git-send-email-jgunthorpe@obsidianresearch.com>
Dear Jason Gunthorpe,
On Thu, 31 Oct 2013 17:32:59 -0600, Jason Gunthorpe wrote:
> When PCI_COMMAND_MEMORY/PCI_COMMAND_IO are cleared the bridge should not
> allocate windows or even look at the window limit/base registers.
>
> Otherwise it can attempt to setup bogus windows that the PCI core code
> creates during discovery. The core will leave PCI_COMMAND_IO cleared if
> it doesn't need an IO window.
>
> Have mvebu_pcie_handle_*_change respect the bits, and call the change
> function whenever the bits changes.
>
> Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
> ---
> drivers/pci/host/pci-mvebu.c | 14 ++++++++++++--
> 1 file changed, 12 insertions(+), 2 deletions(-)
Tested-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: thomas.petazzoni@free-electrons.com (Thomas Petazzoni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] PCI: mvebu - The bridge should obey the MEM and IO command bits
Date: Mon, 25 Nov 2013 18:09:35 +0100 [thread overview]
Message-ID: <20131125180935.37ee3222@skate> (raw)
In-Reply-To: <1383262380-6984-1-git-send-email-jgunthorpe@obsidianresearch.com>
Dear Jason Gunthorpe,
On Thu, 31 Oct 2013 17:32:59 -0600, Jason Gunthorpe wrote:
> When PCI_COMMAND_MEMORY/PCI_COMMAND_IO are cleared the bridge should not
> allocate windows or even look at the window limit/base registers.
>
> Otherwise it can attempt to setup bogus windows that the PCI core code
> creates during discovery. The core will leave PCI_COMMAND_IO cleared if
> it doesn't need an IO window.
>
> Have mvebu_pcie_handle_*_change respect the bits, and call the change
> function whenever the bits changes.
>
> Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
> ---
> drivers/pci/host/pci-mvebu.c | 14 ++++++++++++--
> 1 file changed, 12 insertions(+), 2 deletions(-)
Tested-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2013-11-25 17:09 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-31 23:32 [PATCH 1/2] PCI: mvebu - The bridge should obey the MEM and IO command bits Jason Gunthorpe
2013-10-31 23:32 ` Jason Gunthorpe
2013-10-31 23:33 ` [PATCH v3 2/2] PCI: mvebu - Support a bridge with no IO port window Jason Gunthorpe
2013-10-31 23:33 ` Jason Gunthorpe
2013-11-25 17:10 ` Thomas Petazzoni
2013-11-25 17:10 ` Thomas Petazzoni
2013-11-26 18:06 ` Jason Gunthorpe
2013-11-26 18:06 ` Jason Gunthorpe
2013-11-26 18:10 ` Jason Cooper
2013-11-26 18:10 ` Jason Cooper
2013-11-24 2:58 ` [PATCH 1/2] PCI: mvebu - The bridge should obey the MEM and IO command bits Jason Cooper
2013-11-24 2:58 ` Jason Cooper
2013-11-25 5:52 ` Jason Gunthorpe
2013-11-25 5:52 ` Jason Gunthorpe
2013-11-25 8:12 ` Thomas Petazzoni
2013-11-25 8:12 ` Thomas Petazzoni
2013-11-25 11:29 ` Jason Cooper
2013-11-25 11:29 ` Jason Cooper
2013-11-24 3:00 ` Jason Cooper
2013-11-24 3:00 ` Jason Cooper
2013-11-24 4:00 ` Jason Cooper
2013-11-24 4:00 ` Jason Cooper
2013-11-25 17:09 ` Thomas Petazzoni [this message]
2013-11-25 17:09 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131125180935.37ee3222@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=bhelgaas@google.com \
--cc=ezequiel.garcia@free-electrons.com \
--cc=jason@lakedaemon.net \
--cc=jgunthorpe@obsidianresearch.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.