From mboxrd@z Thu Jan  1 00:00:00 1970
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: Re: [PATCH v2 5/8] tools: dynamically attach/detach CQM
 service for a guest
Date: Mon, 25 Nov 2013 16:01:39 -0500
Message-ID: <20131125210139.GA4348@phenom.dumpdata.com>
References: <1385018444-104477-1-git-send-email-dongxiao.xu@intel.com>
	<1385018444-104477-6-git-send-email-dongxiao.xu@intel.com>
	<20131125210021.GB4217@phenom.dumpdata.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Content-Disposition: inline
In-Reply-To: <20131125210021.GB4217@phenom.dumpdata.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: dongxiao.xu@intel.com
Cc: xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

> > +int libxl_pqos_attach(libxl_ctx *ctx, uint32_t domid, const char * qosres)
> > +{
> > +    int rc;
> > +    int flags = 0;
> > +
> > +    if (!strcmp(qosres, "cqm"))
> > +        flags |= XEN_DOMCTL_ADF_pqos_cqm;

So you make 'flags' an int here, but the hypercall uses uint32_t.

Could you make it the same type please.