From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1Vl0BC-0003g2-8r for mharc-grub-devel@gnu.org; Mon, 25 Nov 2013 12:42:38 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56848) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vl0B4-0003eB-45 for grub-devel@gnu.org; Mon, 25 Nov 2013 12:42:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vl0Ax-0000Hf-IP for grub-devel@gnu.org; Mon, 25 Nov 2013 12:42:30 -0500 Received: from mail-lb0-x234.google.com ([2a00:1450:4010:c04::234]:39747) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vl0Ax-0000Hb-AG for grub-devel@gnu.org; Mon, 25 Nov 2013 12:42:23 -0500 Received: by mail-lb0-f180.google.com with SMTP id w6so3518854lbh.11 for ; Mon, 25 Nov 2013 09:42:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:subject:message-id:in-reply-to:references:mime-version :content-type; bh=GTue6lKObuWktlTS5XbSy/YhXXqUZ6Soi523R8KB4FM=; b=ctZKpSGHRSyeXBFSpKa7sR+iuOwLBoCcy/7LqAXhSV2aZjDq/KwCOoPN3jFck1aOP9 WPxFPJ1TFHEqbIzmrrB1JJnd2uHm1RWg9G5gVvkfiR/N5nD2sZQBmB0OhRY5iYLWPaoz hKWqMheI6PRh9D9Uyd5eOdNFQAIF197givZi8cquCLCWh2ZJsplJ8TqrO0q68DLVRL4k qc7q6LqYfkdxV90lee/5RpE2SBez77ifoQGJgC33eh6/YeahzLdjsXhGAcTgwR4Fq4Ww EPWOB4X270O0pLnQak2NiwfqOsaH3Rs53lfK89smCVE1MiWSHTS1MwkW7b8HPXMIuTuf FqAg== X-Received: by 10.112.143.3 with SMTP id sa3mr22291024lbb.12.1385401342187; Mon, 25 Nov 2013 09:42:22 -0800 (PST) Received: from opensuse.site (ppp91-76-170-113.pppoe.mtu-net.ru. [91.76.170.113]) by mx.google.com with ESMTPSA id ox6sm11284191lbb.6.2013.11.25.09.42.21 for (version=SSLv3 cipher=RC4-SHA bits=128/128); Mon, 25 Nov 2013 09:42:21 -0800 (PST) Date: Mon, 25 Nov 2013 21:42:20 +0400 From: Andrey Borzenkov To: grub-devel@gnu.org Subject: Re: [PATCH] Explicitly check for linking format to use for efiemu64 module Message-ID: <20131125214220.68453de4@opensuse.site> In-Reply-To: <5292D0A2.8040301@gmail.com> References: <1385313664-5982-1-git-send-email-arvidjaar@gmail.com> <5292D0A2.8040301@gmail.com> X-Mailer: Claws Mail 3.9.2 (GTK+ 2.24.18; x86_64-suse-linux-gnu) Mime-Version: 1.0 Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/HO4iGsK3u+ceQJOlIy/yPSr"; protocol="application/pgp-signature" X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c04::234 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Nov 2013 17:42:37 -0000 --Sig_/HO4iGsK3u+ceQJOlIy/yPSr Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable =D0=92 Mon, 25 Nov 2013 05:22:58 +0100 Vladimir '=CF=86-coder/phcoder' Serbinenko =D0=BF=D0=B8= =D1=88=D0=B5=D1=82: > > + CFLAGS=3D"-m64 -nostdlib -O2 -mcmodel=3Dlarge -mno-red-zone" > > + LDFLAGS=3D"-m64 -Wl,$format -nostdlib" > You need -static as otherwise on Apple systems it will try to pull in > the dynamic linker which we don't want (scratch comment about other > thread, I though of adding -static everywhere but it's no necessarry > after all) I used the same flags as in Makefile. If -static is needed here should not it be added to grub-core/Makefile.am as well? > > diff --git a/grub-core/Makefile.am b/grub-core/Makefile.am > > index e2da083..e6862b7 100644 > > --- a/grub-core/Makefile.am > > +++ b/grub-core/Makefile.am > > @@ -421,7 +421,7 @@ efiemu64.o: efiemu64_c.o efiemu64_s.o $(TARGET_OBJ2= ELEF) > > $(TARGET_OBJCONV) -felf64 -nu -nd $@.bin $@ || exit 1; \ > > rm -f $@.bin; \ > Here the check for apple linker has to be adjusted as > x$(EFIEMU64_LINK_FORMAT) =3D x-arch,x86_64 Mmm ... but I assume apple linker case *did* work before and it broke only for the case !TARGET_APPLE_LINKER. Should $(EFIEMU64_LINK_FORMAT) be added for apple linker case as well? I have no way to test it. --Sig_/HO4iGsK3u+ceQJOlIy/yPSr Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) iEYEARECAAYFAlKTi/wACgkQR6LMutpd94x3bACfZ0IosgG/iTLDt9wa76OsY68q W60AmwaS4EVe4oCUw8YXUhWPjIiqV10C =w98O -----END PGP SIGNATURE----- --Sig_/HO4iGsK3u+ceQJOlIy/yPSr--