From: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH 2/3] ARM: tegra: don't hard-code DEBUG_LL baud rate
Date: Tue, 26 Nov 2013 12:08:49 +0100 [thread overview]
Message-ID: <20131126110848.GE27752@ulmo.nvidia.com> (raw)
In-Reply-To: <1385419003-11348-2-git-send-email-swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1250 bytes --]
On Mon, Nov 25, 2013 at 03:36:42PM -0700, Stephen Warren wrote:
> From: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
>
> Stop writing to the UART clock divider registers in the Tegra DEBUG_LL
> code. This allows the DEBUG_LL output to use whatever baud rate was set
> up by the bootloader. Some users are using higher rates than 115200.
>
> This removes the only usage of tegra_uart_config[3], so reduce the size
> allocated for that array.
>
> Finally, fix busyuart() so that it only waits for THRE and not TEMT. For
> some reason, TEMT doesn't get asserted (at least on Tegra30 Beaver) at
> 9600 baud, even though it does at 115200 baud. This sounds like a HW bug,
> but I haven't investigated. For reference, U-Boot's serial code has
> always only checked THRE, and not checked TEMT.
>
> Signed-off-by: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> Tested-by: Paul Walmsley <pwalmsley-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> ---
> arch/arm/include/debug/tegra.S | 30 +++---------------------------
> arch/arm/mach-tegra/tegra.c | 4 +---
> 2 files changed, 4 insertions(+), 30 deletions(-)
Reviewed-by: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: thierry.reding@gmail.com (Thierry Reding)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] ARM: tegra: don't hard-code DEBUG_LL baud rate
Date: Tue, 26 Nov 2013 12:08:49 +0100 [thread overview]
Message-ID: <20131126110848.GE27752@ulmo.nvidia.com> (raw)
In-Reply-To: <1385419003-11348-2-git-send-email-swarren@wwwdotorg.org>
On Mon, Nov 25, 2013 at 03:36:42PM -0700, Stephen Warren wrote:
> From: Stephen Warren <swarren@nvidia.com>
>
> Stop writing to the UART clock divider registers in the Tegra DEBUG_LL
> code. This allows the DEBUG_LL output to use whatever baud rate was set
> up by the bootloader. Some users are using higher rates than 115200.
>
> This removes the only usage of tegra_uart_config[3], so reduce the size
> allocated for that array.
>
> Finally, fix busyuart() so that it only waits for THRE and not TEMT. For
> some reason, TEMT doesn't get asserted (at least on Tegra30 Beaver) at
> 9600 baud, even though it does at 115200 baud. This sounds like a HW bug,
> but I haven't investigated. For reference, U-Boot's serial code has
> always only checked THRE, and not checked TEMT.
>
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> Tested-by: Paul Walmsley <pwalmsley@nvidia.com>
> ---
> arch/arm/include/debug/tegra.S | 30 +++---------------------------
> arch/arm/mach-tegra/tegra.c | 4 +---
> 2 files changed, 4 insertions(+), 30 deletions(-)
Reviewed-by: Thierry Reding <treding@nvidia.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131126/1b7ac321/attachment.sig>
next prev parent reply other threads:[~2013-11-26 11:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-25 22:36 [PATCH 1/3] ARM: tegra: fix DEBUG_LL combined with LPAE Stephen Warren
2013-11-25 22:36 ` Stephen Warren
[not found] ` <1385419003-11348-1-git-send-email-swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-11-25 22:36 ` [PATCH 2/3] ARM: tegra: don't hard-code DEBUG_LL baud rate Stephen Warren
2013-11-25 22:36 ` Stephen Warren
[not found] ` <1385419003-11348-2-git-send-email-swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-11-26 11:08 ` Thierry Reding [this message]
2013-11-26 11:08 ` Thierry Reding
2013-11-25 22:36 ` [PATCH 3/3] ARM: tegra: use section-sized static mappings for LPAE too Stephen Warren
2013-11-25 22:36 ` Stephen Warren
[not found] ` <1385419003-11348-3-git-send-email-swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-11-26 11:13 ` Thierry Reding
2013-11-26 11:13 ` Thierry Reding
2013-11-26 10:21 ` [PATCH 1/3] ARM: tegra: fix DEBUG_LL combined with LPAE Thierry Reding
2013-11-26 10:21 ` Thierry Reding
2013-12-04 19:37 ` Stephen Warren
2013-12-04 19:37 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131126110848.GE27752@ulmo.nvidia.com \
--to=thierry.reding-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
--cc=swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.