From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from arkanian.console-pimps.org ([212.110.184.194]) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1VlJzx-0006G1-Qy for kexec@lists.infradead.org; Tue, 26 Nov 2013 14:52:22 +0000 Date: Tue, 26 Nov 2013 14:51:55 +0000 From: Matt Fleming Subject: Re: [PATCH v4 04/12] efi: cleanup efi_enter_virtual_mode function Message-ID: <20131126145155.GL11521@console-pimps.org> References: <1385445477-9665-1-git-send-email-dyoung@redhat.com> <1385445477-9665-5-git-send-email-dyoung@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1385445477-9665-5-git-send-email-dyoung@redhat.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=twosheds.infradead.org@lists.infradead.org To: Dave Young Cc: mjg59@srcf.ucam.org, linux-efi@vger.kernel.org, toshi.kani@hp.com, greg@kroah.com, x86@kernel.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, James.Bottomley@HansenPartnership.com, horms@verge.net.au, bp@alien8.de, ebiederm@xmission.com, hpa@zytor.com, vgoyal@redhat.com On Tue, 26 Nov, at 01:57:49PM, Dave Young wrote: > Add two small functions: > efi_merge_regions and efi_map_regions, efi_enter_virtual_mode > calls them instead of embedding two long for loop. > > v1->v2: > refresh; coding style fixes. > > v2->v3: > Toshi Kani: > remove unused variable > Matt: check return value of krealloc. > v3->v4: > Boris: Stretch comment to 80 cols > > Signed-off-by: Dave Young > Acked-by: Borislav Petkov > --- > arch/x86/platform/efi/efi.c | 109 +++++++++++++++++++++++++++----------------- > 1 file changed, 66 insertions(+), 43 deletions(-) [...] > @@ -922,9 +948,6 @@ void __init efi_enter_virtual_mode(void) > 0, NULL); > > return; > - > - err_out: > - pr_err("Error reallocating memory, EFI runtime non-functional!\n"); > } > > /* Teeny, tiny comment: You could now delete the above return statement. -- Matt Fleming, Intel Open Source Technology Center _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Fleming Subject: Re: [PATCH v4 04/12] efi: cleanup efi_enter_virtual_mode function Date: Tue, 26 Nov 2013 14:51:55 +0000 Message-ID: <20131126145155.GL11521@console-pimps.org> References: <1385445477-9665-1-git-send-email-dyoung@redhat.com> <1385445477-9665-5-git-send-email-dyoung@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1385445477-9665-5-git-send-email-dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> Sender: linux-efi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Dave Young Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, mjg59-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org, hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org, James.Bottomley-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk@public.gmane.org, vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org, horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org, kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org, greg-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org, toshi.kani-VXdhtT5mjnY@public.gmane.org List-Id: linux-efi@vger.kernel.org On Tue, 26 Nov, at 01:57:49PM, Dave Young wrote: > Add two small functions: > efi_merge_regions and efi_map_regions, efi_enter_virtual_mode > calls them instead of embedding two long for loop. > > v1->v2: > refresh; coding style fixes. > > v2->v3: > Toshi Kani: > remove unused variable > Matt: check return value of krealloc. > v3->v4: > Boris: Stretch comment to 80 cols > > Signed-off-by: Dave Young > Acked-by: Borislav Petkov > --- > arch/x86/platform/efi/efi.c | 109 +++++++++++++++++++++++++++----------------- > 1 file changed, 66 insertions(+), 43 deletions(-) [...] > @@ -922,9 +948,6 @@ void __init efi_enter_virtual_mode(void) > 0, NULL); > > return; > - > - err_out: > - pr_err("Error reallocating memory, EFI runtime non-functional!\n"); > } > > /* Teeny, tiny comment: You could now delete the above return statement. -- Matt Fleming, Intel Open Source Technology Center From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757233Ab3KZOwH (ORCPT ); Tue, 26 Nov 2013 09:52:07 -0500 Received: from arkanian.console-pimps.org ([212.110.184.194]:45163 "EHLO arkanian.console-pimps.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756844Ab3KZOwF (ORCPT ); Tue, 26 Nov 2013 09:52:05 -0500 Date: Tue, 26 Nov 2013 14:51:55 +0000 From: Matt Fleming To: Dave Young Cc: linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org, x86@kernel.org, mjg59@srcf.ucam.org, hpa@zytor.com, James.Bottomley@HansenPartnership.com, vgoyal@redhat.com, ebiederm@xmission.com, horms@verge.net.au, kexec@lists.infradead.org, bp@alien8.de, greg@kroah.com, toshi.kani@hp.com Subject: Re: [PATCH v4 04/12] efi: cleanup efi_enter_virtual_mode function Message-ID: <20131126145155.GL11521@console-pimps.org> References: <1385445477-9665-1-git-send-email-dyoung@redhat.com> <1385445477-9665-5-git-send-email-dyoung@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1385445477-9665-5-git-send-email-dyoung@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 26 Nov, at 01:57:49PM, Dave Young wrote: > Add two small functions: > efi_merge_regions and efi_map_regions, efi_enter_virtual_mode > calls them instead of embedding two long for loop. > > v1->v2: > refresh; coding style fixes. > > v2->v3: > Toshi Kani: > remove unused variable > Matt: check return value of krealloc. > v3->v4: > Boris: Stretch comment to 80 cols > > Signed-off-by: Dave Young > Acked-by: Borislav Petkov > --- > arch/x86/platform/efi/efi.c | 109 +++++++++++++++++++++++++++----------------- > 1 file changed, 66 insertions(+), 43 deletions(-) [...] > @@ -922,9 +948,6 @@ void __init efi_enter_virtual_mode(void) > 0, NULL); > > return; > - > - err_out: > - pr_err("Error reallocating memory, EFI runtime non-functional!\n"); > } > > /* Teeny, tiny comment: You could now delete the above return statement. -- Matt Fleming, Intel Open Source Technology Center