All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: linux-kernel@vger.kernel.org
Cc: ming.lei@canonical.com, mike.marciniszyn@intel.com,
	roland@purestorage.com, dean.luick@intel.com,
	vinit.abhay.agnihotri@intel.com
Subject: Possible bug in firmware/Makefile
Date: Wed, 27 Nov 2013 00:26:58 +0100	[thread overview]
Message-ID: <201311270026.58626.marex@denx.de> (raw)

Hello,

I am observing a possible bug when trying to build external firmware file into 
the kernel. Here are the steps to reproduce the problem I observe.

1) Retrieve Linux 3.13-rc1 (I can confirm this in 3.10.18 stable as well)
2) Clean up the source tree
$ git clean -fdx
3) Configure the kernel (minimal configuration is sufficient)
$ make allnoconfig
4) Produce a dummy firmware file to be built into the kernel
$ echo "hello" > /tmp/firmware.fw
5) Build the kernel (note: I tested this bug on ARCH=arm and ARCH=x86_64)
$ make CONFIG_EXTRA_FIRMWARE="firmware.fw" CONFIG_EXTRA_FIRMWARE_DIR="/tmp/"

What I observe is this output:

  LD      sound/built-in.o
make[1]: *** No rule to make target `include/config/extra/firmware/dir.h', 
needed by `firmware//tmp/firmware.fw.gen.S'.  Stop.
make: *** [firmware] Error 2

Interestingly enough, if I place these same options into the kernel .config, 
using the commands like these below for example, the kernel builds correctly.

echo -e \ 
  'CONFIG_EXTRA_FIRMWARE_DIR="/tmp/"\nCONFIG_EXTRA_FIRMWARE="firmware.fw"' \
  >> .config
make oldconfig
make

Is this a known issue please? Is there a way to specify the extra firmware file 
to be built into the kernel on the kernel build command line please?

Thank you very much!

Best regards,
Marek Vasut

                 reply	other threads:[~2013-11-26 23:27 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201311270026.58626.marex@denx.de \
    --to=marex@denx.de \
    --cc=dean.luick@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mike.marciniszyn@intel.com \
    --cc=ming.lei@canonical.com \
    --cc=roland@purestorage.com \
    --cc=vinit.abhay.agnihotri@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.