From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-out.m-online.net ([212.18.0.9]:41598 "EHLO mail-out.m-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752810Ab3K0IYt (ORCPT ); Wed, 27 Nov 2013 03:24:49 -0500 From: Marek Vasut To: Pratyush Anand Subject: Re: [PATCH RFC] PCI: imx6: remove outbound io/mem ATU region mapping Date: Wed, 27 Nov 2013 09:24:47 +0100 Cc: Tim Harvey , Kishon Vijay Abraham I , "linux-pci@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Bjorn Helgaas , Frank Li , Jingoo Han , Mohit KUMAR DCG , Richard Zhu , Sascha Hauer , Sean Cross , Shawn Guo , Siva Reddy Kallam , Srikanth T Shivanand , Troy Kisky , Yinghai Lu References: <1382504143-27915-1-git-send-email-tharvey@gateworks.com> <201311262146.09780.marex@denx.de> <20131127035056.GA12773@pratyush-vbox> In-Reply-To: <20131127035056.GA12773@pratyush-vbox> MIME-Version: 1.0 Content-Type: Text/Plain; charset="us-ascii" Message-Id: <201311270924.47277.marex@denx.de> Sender: linux-pci-owner@vger.kernel.org List-ID: Dear Pratyush Anand, > On Wed, Nov 27, 2013 at 04:46:09AM +0800, Marek Vasut wrote: > > Dear Pratyush Anand, > > > > > Hi, > > > > > > On Wed, Oct 23, 2013 at 12:55:43PM +0800, Tim Harvey wrote: > > > > The IMX6 iATU is used for address translation between the AXI bus > > > > address space and PCI address space. This is used for type0 and > > > > type1 config cycles but is not necessary for outbound io/mem > > > > regions. > > > > > > > > This patch removes the calls that inappropriately re-configures the > > > > ATU viewport for outbound memory and IO after config cycles and > > > > removes them altogether as they are not necessary. > > > > > > > > This resolves issues with PCI devices behind switches and has been > > > > tested with a Gige device behind a PLX PEX860x switch. More testing > > > > is needed for other configurations. > > > > > > It seems to me that in your controller you have only one view port. > > > Also mem_base and mem_bus_addr is same. Thats why it works in your > > > case. > > > > MX6 has 4 In/4 Out viewports AFAICT. > > Then if I do not miss anything, MX6 should work even without this patch. Yes, yet, it does not. On the other hand, this defect is only problematic if you use the devices behind a switch. Do you use a PCIe switch on your platform please? Best regards, Marek Vasut From mboxrd@z Thu Jan 1 00:00:00 1970 From: marex@denx.de (Marek Vasut) Date: Wed, 27 Nov 2013 09:24:47 +0100 Subject: [PATCH RFC] PCI: imx6: remove outbound io/mem ATU region mapping In-Reply-To: <20131127035056.GA12773@pratyush-vbox> References: <1382504143-27915-1-git-send-email-tharvey@gateworks.com> <201311262146.09780.marex@denx.de> <20131127035056.GA12773@pratyush-vbox> Message-ID: <201311270924.47277.marex@denx.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Dear Pratyush Anand, > On Wed, Nov 27, 2013 at 04:46:09AM +0800, Marek Vasut wrote: > > Dear Pratyush Anand, > > > > > Hi, > > > > > > On Wed, Oct 23, 2013 at 12:55:43PM +0800, Tim Harvey wrote: > > > > The IMX6 iATU is used for address translation between the AXI bus > > > > address space and PCI address space. This is used for type0 and > > > > type1 config cycles but is not necessary for outbound io/mem > > > > regions. > > > > > > > > This patch removes the calls that inappropriately re-configures the > > > > ATU viewport for outbound memory and IO after config cycles and > > > > removes them altogether as they are not necessary. > > > > > > > > This resolves issues with PCI devices behind switches and has been > > > > tested with a Gige device behind a PLX PEX860x switch. More testing > > > > is needed for other configurations. > > > > > > It seems to me that in your controller you have only one view port. > > > Also mem_base and mem_bus_addr is same. Thats why it works in your > > > case. > > > > MX6 has 4 In/4 Out viewports AFAICT. > > Then if I do not miss anything, MX6 should work even without this patch. Yes, yet, it does not. On the other hand, this defect is only problematic if you use the devices behind a switch. Do you use a PCIe switch on your platform please? Best regards, Marek Vasut