From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] ARM: versatile: pass correct machine type for Versatile AB
Date: Wed, 27 Nov 2013 10:55:39 +0100 [thread overview]
Message-ID: <201311271055.40073.marex@denx.de> (raw)
In-Reply-To: <1385544812-22558-1-git-send-email-linus.walleij@linaro.org>
Dear Linus Walleij,
> When U-Boot is configured for Versatile AB, it will still pass
> the machine ID of Versatile PB to the kernel. After this simple
> fix the system boots correctly.
>
> Cc: Stefano Babic <sbabic@denx.de>
> Cc: Marek Vasut <marex@denx.de>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> board/armltd/versatile/versatile.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/board/armltd/versatile/versatile.c
> b/board/armltd/versatile/versatile.c index 30a3b904db4c..4e2d3421d8b1
> 100644
> --- a/board/armltd/versatile/versatile.c
> +++ b/board/armltd/versatile/versatile.c
> @@ -52,7 +52,11 @@ int board_early_init_f (void)
> int board_init (void)
> {
> /* arch number of Versatile Board */
> +#ifdef CONFIG_ARCH_VERSATILE_AB
> + gd->bd->bi_arch_number = MACH_TYPE_VERSATILE_AB;
> +#else
> gd->bd->bi_arch_number = MACH_TYPE_VERSATILE_PB;
> +#endif
>
> /* adress of boot parameters */
> gd->bd->bi_boot_params = 0x00000100;
We should just switch to DT, but I do understand the motivation here. Can you
not detect which board it is dynamically to avoid the ifdef?
Otherwise:
Acked-by: Marek Vasut <marex@denx.de>
Best regards,
Marek Vasut
next prev parent reply other threads:[~2013-11-27 9:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-27 9:33 [U-Boot] [PATCH 1/2] ARM: versatile: pass correct machine type for Versatile AB Linus Walleij
2013-11-27 9:55 ` Marek Vasut [this message]
2013-11-27 12:39 ` Linus Walleij
2013-11-27 12:51 ` Stefano Babic
2013-11-27 13:12 ` Linus Walleij
2013-11-27 10:02 ` Marek Vasut
2013-11-27 12:39 ` Linus Walleij
2014-01-13 8:45 ` Albert ARIBAUD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201311271055.40073.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.