From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from arkanian.console-pimps.org ([212.110.184.194]) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1VldAm-0007sf-10 for kexec@lists.infradead.org; Wed, 27 Nov 2013 11:20:48 +0000 Date: Wed, 27 Nov 2013 11:20:22 +0000 From: Matt Fleming Subject: Re: [PATCH v4 10/12] x86: export x86 boot_params to sysfs Message-ID: <20131127112022.GE18170@console-pimps.org> References: <1385445477-9665-1-git-send-email-dyoung@redhat.com> <1385445477-9665-11-git-send-email-dyoung@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1385445477-9665-11-git-send-email-dyoung@redhat.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=twosheds.infradead.org@lists.infradead.org To: Dave Young Cc: mjg59@srcf.ucam.org, linux-efi@vger.kernel.org, toshi.kani@hp.com, greg@kroah.com, x86@kernel.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, James.Bottomley@HansenPartnership.com, horms@verge.net.au, bp@alien8.de, ebiederm@xmission.com, hpa@zytor.com, vgoyal@redhat.com On Tue, 26 Nov, at 01:57:55PM, Dave Young wrote: > +Users: > + Kexec Mailing List "Kexec" please. > +static ssize_t version_show(struct kobject *kobj, > + struct kobj_attribute *attr, char *buf) This is pretty strange indentation. Usually we prefer to line up the arguments like you've done elsewhere in this file. > +{ > + return sprintf(buf, "0x%04x\n", boot_params.hdr.version); > +} > + > +static struct kobj_attribute boot_params_version_attr = __ATTR_RO(version); > + > +static ssize_t boot_params_data_read(struct file *fp, struct kobject *kobj, > + struct bin_attribute *bin_attr, > + char *buf, loff_t off, size_t count) > +{ > + memcpy(buf, (void *)&boot_params + off, count); > + return count; > +} Don't we need some checks here to ensure we don't read past the end of boot_params? > +static ssize_t type_show(struct kobject *kobj, > + struct kobj_attribute *attr, char *buf) More whacky indentation. > +static int __init create_setup_data_node(struct kobject *parent, > + struct kobject **kobjp, int nr) Funky indentation. -- Matt Fleming, Intel Open Source Technology Center _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Fleming Subject: Re: [PATCH v4 10/12] x86: export x86 boot_params to sysfs Date: Wed, 27 Nov 2013 11:20:22 +0000 Message-ID: <20131127112022.GE18170@console-pimps.org> References: <1385445477-9665-1-git-send-email-dyoung@redhat.com> <1385445477-9665-11-git-send-email-dyoung@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1385445477-9665-11-git-send-email-dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> Sender: linux-efi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Dave Young Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, mjg59-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org, hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org, James.Bottomley-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk@public.gmane.org, vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org, horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org, kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org, greg-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org, toshi.kani-VXdhtT5mjnY@public.gmane.org List-Id: linux-efi@vger.kernel.org On Tue, 26 Nov, at 01:57:55PM, Dave Young wrote: > +Users: > + Kexec Mailing List "Kexec" please. > +static ssize_t version_show(struct kobject *kobj, > + struct kobj_attribute *attr, char *buf) This is pretty strange indentation. Usually we prefer to line up the arguments like you've done elsewhere in this file. > +{ > + return sprintf(buf, "0x%04x\n", boot_params.hdr.version); > +} > + > +static struct kobj_attribute boot_params_version_attr = __ATTR_RO(version); > + > +static ssize_t boot_params_data_read(struct file *fp, struct kobject *kobj, > + struct bin_attribute *bin_attr, > + char *buf, loff_t off, size_t count) > +{ > + memcpy(buf, (void *)&boot_params + off, count); > + return count; > +} Don't we need some checks here to ensure we don't read past the end of boot_params? > +static ssize_t type_show(struct kobject *kobj, > + struct kobj_attribute *attr, char *buf) More whacky indentation. > +static int __init create_setup_data_node(struct kobject *parent, > + struct kobject **kobjp, int nr) Funky indentation. -- Matt Fleming, Intel Open Source Technology Center From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753905Ab3K0LUc (ORCPT ); Wed, 27 Nov 2013 06:20:32 -0500 Received: from arkanian.console-pimps.org ([212.110.184.194]:52127 "EHLO arkanian.console-pimps.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752099Ab3K0LU3 (ORCPT ); Wed, 27 Nov 2013 06:20:29 -0500 Date: Wed, 27 Nov 2013 11:20:22 +0000 From: Matt Fleming To: Dave Young Cc: linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org, x86@kernel.org, mjg59@srcf.ucam.org, hpa@zytor.com, James.Bottomley@HansenPartnership.com, vgoyal@redhat.com, ebiederm@xmission.com, horms@verge.net.au, kexec@lists.infradead.org, bp@alien8.de, greg@kroah.com, toshi.kani@hp.com Subject: Re: [PATCH v4 10/12] x86: export x86 boot_params to sysfs Message-ID: <20131127112022.GE18170@console-pimps.org> References: <1385445477-9665-1-git-send-email-dyoung@redhat.com> <1385445477-9665-11-git-send-email-dyoung@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1385445477-9665-11-git-send-email-dyoung@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 26 Nov, at 01:57:55PM, Dave Young wrote: > +Users: > + Kexec Mailing List "Kexec" please. > +static ssize_t version_show(struct kobject *kobj, > + struct kobj_attribute *attr, char *buf) This is pretty strange indentation. Usually we prefer to line up the arguments like you've done elsewhere in this file. > +{ > + return sprintf(buf, "0x%04x\n", boot_params.hdr.version); > +} > + > +static struct kobj_attribute boot_params_version_attr = __ATTR_RO(version); > + > +static ssize_t boot_params_data_read(struct file *fp, struct kobject *kobj, > + struct bin_attribute *bin_attr, > + char *buf, loff_t off, size_t count) > +{ > + memcpy(buf, (void *)&boot_params + off, count); > + return count; > +} Don't we need some checks here to ensure we don't read past the end of boot_params? > +static ssize_t type_show(struct kobject *kobj, > + struct kobj_attribute *attr, char *buf) More whacky indentation. > +static int __init create_setup_data_node(struct kobject *parent, > + struct kobject **kobjp, int nr) Funky indentation. -- Matt Fleming, Intel Open Source Technology Center