From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail.skyhub.de ([2a01:4f8:120:8448::d00d]) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1VlgY3-00065C-Nf for kexec@lists.infradead.org; Wed, 27 Nov 2013 14:57:06 +0000 Date: Wed, 27 Nov 2013 15:56:34 +0100 From: Borislav Petkov Subject: Re: [PATCH v4 10/12] x86: export x86 boot_params to sysfs Message-ID: <20131127145634.GG32267@pd.tnic> References: <1385445477-9665-1-git-send-email-dyoung@redhat.com> <1385445477-9665-11-git-send-email-dyoung@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1385445477-9665-11-git-send-email-dyoung@redhat.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "kexec" Errors-To: kexec-bounces+dwmw2=twosheds.infradead.org@lists.infradead.org To: Dave Young Cc: mjg59@srcf.ucam.org, linux-efi@vger.kernel.org, toshi.kani@hp.com, matt@console-pimps.org, greg@kroah.com, x86@kernel.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, James.Bottomley@HansenPartnership.com, horms@verge.net.au, ebiederm@xmission.com, hpa@zytor.com, vgoyal@redhat.com T24gVHVlLCBOb3YgMjYsIDIwMTMgYXQgMDE6NTc6NTVQTSArMDgwMCwgRGF2ZSBZb3VuZyB3cm90 ZToKPiBrZXhlYy10b29scyB1c2UgYm9vdF9wYXJhbXMgZm9yIGdldHRpbmcgdGhlIDFzdCBrZXJu ZWwgaGFyZHdhcmVfc3ViYXJjaCwKPiB0aGUga2V4ZWMga2VybmVsIGVmaSBydW50aW1lIHN1cHBv cnQgYWxzbyBuZWVkIHJlYWQgdGhlIG9sZCBlZmlfaW5mbyBmcm9tCj4gYm9vdF9wYXJhbXMuIEN1 cnJlbnRseSBpdCBleGlzdHMgaW4gZGVidWdmcyB3aGljaCBpcyBub3QgYSBnb29kIHBsYWNlIGZv cgo+IHN1Y2ggaW5mb21hdGlvbi4gUGVyIEhQQSwgd2Ugc2hvdWxkIGF2b2lkIG9mICJzcGxvaXQg ZGVidWdmcyIuCj4gCj4gSW4gdGhpcyBwYXRjaCAvc3lzL2tlcm5lbC9ib290X3BhcmFtcyBhcmUg ZXhwb3J0ZWQsIGFsc28gdGhlIHNldHVwX2RhdGEKPiBpcyBleHBvcnRlZCBhcyBhIHN1YmRpcmVj dG9yeS4gRm9yIG9yaWdpbmFsIGRlYnVnZnMgc2luY2UgaXQncyBhbHJlYWR5Cj4gdGhlcmUgZm9y IGxvbmcgdGltZSBhbmQga2V4ZWMtdG9vbHMgaXMgdXNpbmcgaXQgZm9yIGhhcmR3YXJlX3N1YmFy Y2ggc28KPiBsZXQncyBkbyBub3QgcmVtb3ZlIHRoZW0gZm9yIG5vdy4KCiJrZXhlYy10b29scyBp cyB1c2luZyBkZWJ1Z2ZzIGZvciBoYXJkd2FyZV9zdWJhcmNoIGZvciBhIGxvbmcgdGltZSBub3cK c28gd2UncmUgbm90IHJlbW92aW5nIGl0IHlldC4iCgo+IFN0cnVjdHVyZSBhcmUgbGlrZSBiZWxv dzoKCgkgICAgaXMKCj4gCj4gL3N5cy9rZXJuZWwvYm9vdF9wYXJhbXMKPiDilJzilIDilIAgZGF0 YQkJLyogYmluYXJ5IGRhdGEgZm9yIGJvb3RfcGFyYW1zICovCgpZb3UgbWVhbiAiYm9vdF9wYXJh bXMgaW4gYmluYXJ5Ij8KCj4g4pSc4pSA4pSAIHNldHVwX2RhdGEgIAkvKiBzdWJkaXJlY3Rvcnkg Zm9yIHNldHVwX2RhdGEgaWYgdGhlcmUncyBhbnkgKi8KCm5vIG5lZWQgZm9yIHRoYXQgY29tbWVu dAoKPiDilILCoMKgIOKUnOKUgOKUgCAwCQkvKiB0aGUgZmlyc3Qgc2V0dXBfZGF0YSBub2RlICov Cj4g4pSCwqDCoCDilILCoMKgIOKUnOKUgOKUgCBkYXRhCS8qIGJpbmFyeSBkYXRhIGZvciBzZXR1 cF9kYXRhIG5vZGUgMCAqLwoKInNldHVwX2RhdGEgbm9kZSAwIGluIGJpbmFyeSIKCj4g4pSCwqDC oCDilILCoMKgIOKUlOKUgOKUgCB0eXBlCS8qIHNldHVwX2RhdGEgdHlwZSBvZiBzZXR1cF9kYXRh IG5vZGUgMCwgaGV4IHN0cmluZyAqLwo+IHwgICBbc25pcF0JCS8qIG90aGVyIHNldHVwX2RhdGEg bm9kZXMgLi4uICovCj4g4pSU4pSA4pSAIHZlcnNpb24JCS8qIGhleCBzdHJpbmcgZm9yIGJvb3Qg cHJvdG9jYWwgdmVyc2lvbiAqLwoKImJvb3QgcHJvdG9jb2wgdmVyc2lvbiAoaW4gaGV4LCAiMHgi IHByZWZpeGVkKSIKCj4gCj4gQ2hhbmdlbG9nOgo+IEdyZWc6IHVzZSBfX0FUVFJfUk8oKSBhbmQg Z3JvdXAgYXR0ci4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBEYXZlIFlvdW5nIDxkeW91bmdAcmVkaGF0 LmNvbT4KPiAtLS0KPiAgRG9jdW1lbnRhdGlvbi9BQkkvdGVzdGluZy9zeXNmcy1rZXJuZWwtYm9v dF9wYXJhbXMgfCAgNDAgKysrCj4gIGFyY2gveDg2L2tlcm5lbC9NYWtlZmlsZSAgICAgICAgICAg ICAgICAgICAgICAgICAgIHwgICAyICstCj4gIGFyY2gveDg2L2tlcm5lbC9rc3lzZnMuYyAgICAg ICAgICAgICAgICAgICAgICAgICAgIHwgMzM5ICsrKysrKysrKysrKysrKysrKysrKwo+ICAzIGZp bGVzIGNoYW5nZWQsIDM4MCBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCj4gIGNyZWF0ZSBt b2RlIDEwMDY0NCBEb2N1bWVudGF0aW9uL0FCSS90ZXN0aW5nL3N5c2ZzLWtlcm5lbC1ib290X3Bh cmFtcwo+ICBjcmVhdGUgbW9kZSAxMDA2NDQgYXJjaC94ODYva2VybmVsL2tzeXNmcy5jCj4gCj4g ZGlmZiAtLWdpdCBhL0RvY3VtZW50YXRpb24vQUJJL3Rlc3Rpbmcvc3lzZnMta2VybmVsLWJvb3Rf cGFyYW1zIGIvRG9jdW1lbnRhdGlvbi9BQkkvdGVzdGluZy9zeXNmcy1rZXJuZWwtYm9vdF9wYXJh bXMKPiBuZXcgZmlsZSBtb2RlIDEwMDY0NAo+IGluZGV4IDAwMDAwMDAuLjgwMTRhOTMKPiAtLS0g L2Rldi9udWxsCj4gKysrIGIvRG9jdW1lbnRhdGlvbi9BQkkvdGVzdGluZy9zeXNmcy1rZXJuZWwt Ym9vdF9wYXJhbXMKPiBAQCAtMCwwICsxLDQwIEBACj4gK1doYXQ6CQkvc3lzL2tlcm5lbC9ib290 X3BhcmFtcwo+ICtEYXRlOgkJTm92ZW1iZXIgMjAxMwo+ICtDb250YWN0OglEYXZlIFlvdW5nIDxk eW91bmdAcmVkaGF0LmNvbT4KPiArRGVzY3JpcHRpb246Cj4gKwkJVGhlIC9zeXMva2VybmVsL2Jv b3RfcGFyYW1zIGRpcmVjdG9yeSBjb250YWlucyB0d28KPiArCQlmaWxlczogImRhdGEiIGFuZCAi dmVyc2lvbiIgYW5kIG9uZSBzdWJkaXJlY3RvcnkgInNldHVwX2RhdGEiLgo+ICsJCUl0IGlzIHVz ZWQgdG8gZXhwb3J0IHRoZSBrZXJuZWwgYm9vdCBwYXJhbWV0ZXJzIG9mIHg4NgoKIi4uLiBvZiBh biB4ODYgcGxhdGZvcm0gdG8gdXNlcnNwYWNlIGZvciBrZXhlYyBhbmQgZGVidWdnaW5nIHB1cnBv c2VzLiIKCj4gKwkJcGxhdGZvcm0gdG8gdXNlciBzcGFjZSBmb3Iga2V4ZWMgYW5kIGRlYnVnZ2lu ZyBwdXJwb3NlLgo+ICsKPiArCQlJZiB0aGVyZSdzIG5vIHNldHVwX2RhdGEgaW4gYm9vdF9wYXJh bXMgdGhlIHN1YmRpcmVjdG9yeSB3aWxsCj4gKwkJbm90IGJlIGNyZWF0ZWQuCj4gKwo+ICsJCSJk YXRhIiBmaWxlIGlzIHRoZSBiaW5hcnkgcmVwcmVzZW50YXRpb24gb2Ygc3RydWN0IGJvb3RfcGFy YW1zLgo+ICsKPiArCQkidmVyc2lvbiIgZmlsZSBpcyB0aGUgc3RyaW5nIHJlcHJlc2VudGF0aW9u IG9mIGJvb3QKPiArCQlwcm90b2NvbCB2ZXJzaW9uLgo+ICsKPiArCQkic2V0dXBfZGF0YSIgc3Vi ZGlyZWN0b3J5IGNvbnRhaW5zIHRoZSBzZXR1cF9kYXRhIGRhdGEKPiArCQlzdHJ1Y3R1cmUgaW4g Ym9vdF9wYXJhbXMuIHNldHVwX2RhdGEgaXMgbWFpbnRhaW5lZCBpbiBrZXJuZWwKPiArCQlhcyBh IGxpbmsgbGlzdC4gSW4gInNldHVwX2RhdGEiIHN1YmRpcmVjdG9yeSB0aGVyZSdzIG9uZQo+ICsJ CXN1YmRpcmVjdG9yeSBmb3IgZWFjaCBsaW5rIGxpc3Qgbm9kZSBuYW1lZCB3aXRoIHRoZSBudW1i ZXIKPiArCQlvZiB0aGUgbGlzdCBub2Rlcy4gVGhlIGxpc3Qgbm9kZSBzdWJkaXJlY3RvcnkgY29u dGFpbnMgdHdvCj4gKwkJZmlsZXMgInR5cGUiIGFuZCAiZGF0YSIuICJ0eXBlIiBmaWxlIGlzIHRo ZSBzdHJpbmcKPiArCQlyZXByZXNlbnRhdGlvbiBvZiBzZXR1cF9kYXRhIHR5cGUuCgpzdHJpbmcg b3IgaW50Pwo+ICsJCSJkYXRhIiBmaWxlIGlzIHRoZSBiaW5hcnkKPiArCQlyZXByZXNlbnRhdGlv biBvZiBzZXR1cF9kYXRhIHBheWxvYWQuCj4gKwo+ICsJCVRoZSB3aG9sZSBib290X3BhcmFtcyBk aXJlY3Rvcnkgc3RydWN0dXJlIGlzIGxpa2UgYmVsb3c6Cj4gKwkJL3N5cy9rZXJuZWwvYm9vdF9w YXJhbXMKPiArCQnilJzilIDilIAgZGF0YQo+ICsJCeKUnOKUgOKUgCBzZXR1cF9kYXRhCj4gKwkJ 4pSCwqDCoCDilJzilIDilIAgMAo+ICsJCeKUgsKgwqAg4pSCwqDCoCDilJzilIDilIAgZGF0YQo+ ICsJCeKUgsKgwqAg4pSCwqDCoCDilJTilIDilIAgdHlwZQo+ICsJCeKUgsKgwqAg4pSU4pSA4pSA IDEKPiArCQnilILCoMKgICAgICDilJzilIDilIAgZGF0YQo+ICsJCeKUgsKgwqAgICAgIOKUlOKU gOKUgCB0eXBlCj4gKwkJ4pSU4pSA4pSAIHZlcnNpb24KPiArCj4gK1VzZXJzOgo+ICsJCUtleGVj IE1haWxpbmcgTGlzdCA8a2V4ZWNAbGlzdHMuaW5mcmFkZWFkLm9yZz4KPiBkaWZmIC0tZ2l0IGEv YXJjaC94ODYva2VybmVsL01ha2VmaWxlIGIvYXJjaC94ODYva2VybmVsL01ha2VmaWxlCj4gaW5k ZXggYTU0MDhiOS4uNDczYTRiYiAxMDA2NDQKPiAtLS0gYS9hcmNoL3g4Ni9rZXJuZWwvTWFrZWZp bGUKPiArKysgYi9hcmNoL3g4Ni9rZXJuZWwvTWFrZWZpbGUKPiBAQCAtMzUsNyArMzUsNyBAQCBv YmoteQkJCSs9IGFsdGVybmF0aXZlLm8gaTgyNTMubyBwY2ktbm9tbXUubyBod19icmVha3BvaW50 Lm8KPiAgb2JqLXkJCQkrPSB0c2MubyBpb19kZWxheS5vIHJ0Yy5vCj4gIG9iai15CQkJKz0gcGNp LWlvbW11X3RhYmxlLm8KPiAgb2JqLXkJCQkrPSByZXNvdXJjZS5vCj4gLQo+ICtvYmotJChDT05G SUdfU1lTRlMpCSs9IGtzeXNmcy5vCj4gIG9iai15CQkJCSs9IHByb2Nlc3Mubwo+ICBvYmoteQkJ CQkrPSBpMzg3Lm8geHNhdmUubwo+ICBvYmoteQkJCQkrPSBwdHJhY2UubwoKQ29uZmxpY3Qgd2l0 aCB1cHN0cmVhbSwgaXQgc2hvdWxkIGJlOgoKZGlmZiAtLWdpdCBhL2FyY2gveDg2L2tlcm5lbC9N YWtlZmlsZSBiL2FyY2gveDg2L2tlcm5lbC9NYWtlZmlsZQppbmRleCA5YjBhMzRlMmNkNzkuLjg1 MWRjZDEyMThmYyAxMDA2NDQKLS0tIGEvYXJjaC94ODYva2VybmVsL01ha2VmaWxlCisrKyBiL2Fy Y2gveDg2L2tlcm5lbC9NYWtlZmlsZQpAQCAtMzUsNiArMzUsNyBAQCBvYmoteSAgICAgICAgICAg ICAgICAgKz0gYWx0ZXJuYXRpdmUubyBpODI1My5vIHBjaS1ub21tdS5vIGh3X2JyZWFrcG9pbnQu bwogb2JqLXkgICAgICAgICAgICAgICAgICArPSB0c2MubyBpb19kZWxheS5vIHJ0Yy5vCiBvYmot eSAgICAgICAgICAgICAgICAgICs9IHBjaS1pb21tdV90YWJsZS5vCiBvYmoteSAgICAgICAgICAg ICAgICAgICs9IHJlc291cmNlLm8KK29iai0kKENPTkZJR19TWVNGUykgICAgKz0ga3N5c2ZzLm8K IAogb2JqLSQoQ09ORklHX1BSRUVNUFQpICArPSBwcmVlbXB0Lm8KIAoKPiBkaWZmIC0tZ2l0IGEv YXJjaC94ODYva2VybmVsL2tzeXNmcy5jIGIvYXJjaC94ODYva2VybmVsL2tzeXNmcy5jCj4gbmV3 IGZpbGUgbW9kZSAxMDA2NDQKPiBpbmRleCAwMDAwMDAwLi4zZjkxMjA3Cj4gLS0tIC9kZXYvbnVs bAo+ICsrKyBiL2FyY2gveDg2L2tlcm5lbC9rc3lzZnMuYwo+IEBAIC0wLDAgKzEsMzM5IEBACj4g Ky8qCj4gKyAqIEFyY2hpdGVjdHVyZSBzcGVjaWZpYyBzeXNmcyBhdHRyaWJ1dGVzIGluIC9zeXMv a2VybmVsCgpBcmNoaXRlY3R1cmUtc3BlY2lmaWMKCi4uLgoKLS0gClJlZ2FyZHMvR3J1c3MsCiAg ICBCb3Jpcy4KClNlbnQgZnJvbSBhIGZhdCBjcmF0ZSB1bmRlciBteSBkZXNrLiBGb3JtYXR0aW5n IGlzIGZpbmUuCi0tCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwprZXhlYyBtYWlsaW5nIGxpc3QKa2V4ZWNAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8v bGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2tleGVjCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: Borislav Petkov Subject: Re: [PATCH v4 10/12] x86: export x86 boot_params to sysfs Date: Wed, 27 Nov 2013 15:56:34 +0100 Message-ID: <20131127145634.GG32267@pd.tnic> References: <1385445477-9665-1-git-send-email-dyoung@redhat.com> <1385445477-9665-11-git-send-email-dyoung@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <1385445477-9665-11-git-send-email-dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> Sender: linux-efi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Dave Young Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, mjg59-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org, hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org, James.Bottomley-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk@public.gmane.org, vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org, horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org, kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, greg-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org, matt-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org, toshi.kani-VXdhtT5mjnY@public.gmane.org List-Id: linux-efi@vger.kernel.org On Tue, Nov 26, 2013 at 01:57:55PM +0800, Dave Young wrote: > kexec-tools use boot_params for getting the 1st kernel hardware_subar= ch, > the kexec kernel efi runtime support also need read the old efi_info = from > boot_params. Currently it exists in debugfs which is not a good place= for > such infomation. Per HPA, we should avoid of "sploit debugfs". >=20 > In this patch /sys/kernel/boot_params are exported, also the setup_da= ta > is exported as a subdirectory. For original debugfs since it's alread= y > there for long time and kexec-tools is using it for hardware_subarch = so > let's do not remove them for now. "kexec-tools is using debugfs for hardware_subarch for a long time now so we're not removing it yet." > Structure are like below: is >=20 > /sys/kernel/boot_params > =E2=94=9C=E2=94=80=E2=94=80 data /* binary data for boot_params */ You mean "boot_params in binary"? > =E2=94=9C=E2=94=80=E2=94=80 setup_data /* subdirectory for setup_da= ta if there's any */ no need for that comment > =E2=94=82=C2=A0=C2=A0 =E2=94=9C=E2=94=80=E2=94=80 0 /* the first set= up_data node */ > =E2=94=82=C2=A0=C2=A0 =E2=94=82=C2=A0=C2=A0 =E2=94=9C=E2=94=80=E2=94=80= data /* binary data for setup_data node 0 */ "setup_data node 0 in binary" > =E2=94=82=C2=A0=C2=A0 =E2=94=82=C2=A0=C2=A0 =E2=94=94=E2=94=80=E2=94=80= type /* setup_data type of setup_data node 0, hex string */ > | [snip] /* other setup_data nodes ... */ > =E2=94=94=E2=94=80=E2=94=80 version /* hex string for boot protocal = version */ "boot protocol version (in hex, "0x" prefixed)" >=20 > Changelog: > Greg: use __ATTR_RO() and group attr. >=20 > Signed-off-by: Dave Young > --- > Documentation/ABI/testing/sysfs-kernel-boot_params | 40 +++ > arch/x86/kernel/Makefile | 2 +- > arch/x86/kernel/ksysfs.c | 339 +++++++++++= ++++++++++ > 3 files changed, 380 insertions(+), 1 deletion(-) > create mode 100644 Documentation/ABI/testing/sysfs-kernel-boot_param= s > create mode 100644 arch/x86/kernel/ksysfs.c >=20 > diff --git a/Documentation/ABI/testing/sysfs-kernel-boot_params b/Doc= umentation/ABI/testing/sysfs-kernel-boot_params > new file mode 100644 > index 0000000..8014a93 > --- /dev/null > +++ b/Documentation/ABI/testing/sysfs-kernel-boot_params > @@ -0,0 +1,40 @@ > +What: /sys/kernel/boot_params > +Date: November 2013 > +Contact: Dave Young > +Description: > + The /sys/kernel/boot_params directory contains two > + files: "data" and "version" and one subdirectory "setup_data". > + It is used to export the kernel boot parameters of x86 "... of an x86 platform to userspace for kexec and debugging purposes." > + platform to user space for kexec and debugging purpose. > + > + If there's no setup_data in boot_params the subdirectory will > + not be created. > + > + "data" file is the binary representation of struct boot_params. > + > + "version" file is the string representation of boot > + protocol version. > + > + "setup_data" subdirectory contains the setup_data data > + structure in boot_params. setup_data is maintained in kernel > + as a link list. In "setup_data" subdirectory there's one > + subdirectory for each link list node named with the number > + of the list nodes. The list node subdirectory contains two > + files "type" and "data". "type" file is the string > + representation of setup_data type. string or int? > + "data" file is the binary > + representation of setup_data payload. > + > + The whole boot_params directory structure is like below: > + /sys/kernel/boot_params > + =E2=94=9C=E2=94=80=E2=94=80 data > + =E2=94=9C=E2=94=80=E2=94=80 setup_data > + =E2=94=82=C2=A0=C2=A0 =E2=94=9C=E2=94=80=E2=94=80 0 > + =E2=94=82=C2=A0=C2=A0 =E2=94=82=C2=A0=C2=A0 =E2=94=9C=E2=94=80=E2=94= =80 data > + =E2=94=82=C2=A0=C2=A0 =E2=94=82=C2=A0=C2=A0 =E2=94=94=E2=94=80=E2=94= =80 type > + =E2=94=82=C2=A0=C2=A0 =E2=94=94=E2=94=80=E2=94=80 1 > + =E2=94=82=C2=A0=C2=A0 =E2=94=9C=E2=94=80=E2=94=80 data > + =E2=94=82=C2=A0=C2=A0 =E2=94=94=E2=94=80=E2=94=80 type > + =E2=94=94=E2=94=80=E2=94=80 version > + > +Users: > + Kexec Mailing List > diff --git a/arch/x86/kernel/Makefile b/arch/x86/kernel/Makefile > index a5408b9..473a4bb 100644 > --- a/arch/x86/kernel/Makefile > +++ b/arch/x86/kernel/Makefile > @@ -35,7 +35,7 @@ obj-y +=3D alternative.o i8253.o pci-nommu.o hw_b= reakpoint.o > obj-y +=3D tsc.o io_delay.o rtc.o > obj-y +=3D pci-iommu_table.o > obj-y +=3D resource.o > - > +obj-$(CONFIG_SYSFS) +=3D ksysfs.o > obj-y +=3D process.o > obj-y +=3D i387.o xsave.o > obj-y +=3D ptrace.o Conflict with upstream, it should be: diff --git a/arch/x86/kernel/Makefile b/arch/x86/kernel/Makefile index 9b0a34e2cd79..851dcd1218fc 100644 --- a/arch/x86/kernel/Makefile +++ b/arch/x86/kernel/Makefile @@ -35,6 +35,7 @@ obj-y +=3D alternative.o i8253.o pci-= nommu.o hw_breakpoint.o obj-y +=3D tsc.o io_delay.o rtc.o obj-y +=3D pci-iommu_table.o obj-y +=3D resource.o +obj-$(CONFIG_SYSFS) +=3D ksysfs.o =20 obj-$(CONFIG_PREEMPT) +=3D preempt.o =20 > diff --git a/arch/x86/kernel/ksysfs.c b/arch/x86/kernel/ksysfs.c > new file mode 100644 > index 0000000..3f91207 > --- /dev/null > +++ b/arch/x86/kernel/ksysfs.c > @@ -0,0 +1,339 @@ > +/* > + * Architecture specific sysfs attributes in /sys/kernel Architecture-specific =2E.. --=20 Regards/Gruss, Boris. Sent from a fat crate under my desk. Formatting is fine. -- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756632Ab3K0O4s (ORCPT ); Wed, 27 Nov 2013 09:56:48 -0500 Received: from mail.skyhub.de ([78.46.96.112]:50912 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750905Ab3K0O4m (ORCPT ); Wed, 27 Nov 2013 09:56:42 -0500 Date: Wed, 27 Nov 2013 15:56:34 +0100 From: Borislav Petkov To: Dave Young Cc: linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org, x86@kernel.org, mjg59@srcf.ucam.org, hpa@zytor.com, James.Bottomley@HansenPartnership.com, vgoyal@redhat.com, ebiederm@xmission.com, horms@verge.net.au, kexec@lists.infradead.org, greg@kroah.com, matt@console-pimps.org, toshi.kani@hp.com Subject: Re: [PATCH v4 10/12] x86: export x86 boot_params to sysfs Message-ID: <20131127145634.GG32267@pd.tnic> References: <1385445477-9665-1-git-send-email-dyoung@redhat.com> <1385445477-9665-11-git-send-email-dyoung@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1385445477-9665-11-git-send-email-dyoung@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 26, 2013 at 01:57:55PM +0800, Dave Young wrote: > kexec-tools use boot_params for getting the 1st kernel hardware_subarch, > the kexec kernel efi runtime support also need read the old efi_info from > boot_params. Currently it exists in debugfs which is not a good place for > such infomation. Per HPA, we should avoid of "sploit debugfs". > > In this patch /sys/kernel/boot_params are exported, also the setup_data > is exported as a subdirectory. For original debugfs since it's already > there for long time and kexec-tools is using it for hardware_subarch so > let's do not remove them for now. "kexec-tools is using debugfs for hardware_subarch for a long time now so we're not removing it yet." > Structure are like below: is > > /sys/kernel/boot_params > ├── data /* binary data for boot_params */ You mean "boot_params in binary"? > ├── setup_data /* subdirectory for setup_data if there's any */ no need for that comment > │   ├── 0 /* the first setup_data node */ > │   │   ├── data /* binary data for setup_data node 0 */ "setup_data node 0 in binary" > │   │   └── type /* setup_data type of setup_data node 0, hex string */ > | [snip] /* other setup_data nodes ... */ > └── version /* hex string for boot protocal version */ "boot protocol version (in hex, "0x" prefixed)" > > Changelog: > Greg: use __ATTR_RO() and group attr. > > Signed-off-by: Dave Young > --- > Documentation/ABI/testing/sysfs-kernel-boot_params | 40 +++ > arch/x86/kernel/Makefile | 2 +- > arch/x86/kernel/ksysfs.c | 339 +++++++++++++++++++++ > 3 files changed, 380 insertions(+), 1 deletion(-) > create mode 100644 Documentation/ABI/testing/sysfs-kernel-boot_params > create mode 100644 arch/x86/kernel/ksysfs.c > > diff --git a/Documentation/ABI/testing/sysfs-kernel-boot_params b/Documentation/ABI/testing/sysfs-kernel-boot_params > new file mode 100644 > index 0000000..8014a93 > --- /dev/null > +++ b/Documentation/ABI/testing/sysfs-kernel-boot_params > @@ -0,0 +1,40 @@ > +What: /sys/kernel/boot_params > +Date: November 2013 > +Contact: Dave Young > +Description: > + The /sys/kernel/boot_params directory contains two > + files: "data" and "version" and one subdirectory "setup_data". > + It is used to export the kernel boot parameters of x86 "... of an x86 platform to userspace for kexec and debugging purposes." > + platform to user space for kexec and debugging purpose. > + > + If there's no setup_data in boot_params the subdirectory will > + not be created. > + > + "data" file is the binary representation of struct boot_params. > + > + "version" file is the string representation of boot > + protocol version. > + > + "setup_data" subdirectory contains the setup_data data > + structure in boot_params. setup_data is maintained in kernel > + as a link list. In "setup_data" subdirectory there's one > + subdirectory for each link list node named with the number > + of the list nodes. The list node subdirectory contains two > + files "type" and "data". "type" file is the string > + representation of setup_data type. string or int? > + "data" file is the binary > + representation of setup_data payload. > + > + The whole boot_params directory structure is like below: > + /sys/kernel/boot_params > + ├── data > + ├── setup_data > + │   ├── 0 > + │   │   ├── data > + │   │   └── type > + │   └── 1 > + │   ├── data > + │   └── type > + └── version > + > +Users: > + Kexec Mailing List > diff --git a/arch/x86/kernel/Makefile b/arch/x86/kernel/Makefile > index a5408b9..473a4bb 100644 > --- a/arch/x86/kernel/Makefile > +++ b/arch/x86/kernel/Makefile > @@ -35,7 +35,7 @@ obj-y += alternative.o i8253.o pci-nommu.o hw_breakpoint.o > obj-y += tsc.o io_delay.o rtc.o > obj-y += pci-iommu_table.o > obj-y += resource.o > - > +obj-$(CONFIG_SYSFS) += ksysfs.o > obj-y += process.o > obj-y += i387.o xsave.o > obj-y += ptrace.o Conflict with upstream, it should be: diff --git a/arch/x86/kernel/Makefile b/arch/x86/kernel/Makefile index 9b0a34e2cd79..851dcd1218fc 100644 --- a/arch/x86/kernel/Makefile +++ b/arch/x86/kernel/Makefile @@ -35,6 +35,7 @@ obj-y += alternative.o i8253.o pci-nommu.o hw_breakpoint.o obj-y += tsc.o io_delay.o rtc.o obj-y += pci-iommu_table.o obj-y += resource.o +obj-$(CONFIG_SYSFS) += ksysfs.o obj-$(CONFIG_PREEMPT) += preempt.o > diff --git a/arch/x86/kernel/ksysfs.c b/arch/x86/kernel/ksysfs.c > new file mode 100644 > index 0000000..3f91207 > --- /dev/null > +++ b/arch/x86/kernel/ksysfs.c > @@ -0,0 +1,339 @@ > +/* > + * Architecture specific sysfs attributes in /sys/kernel Architecture-specific ... -- Regards/Gruss, Boris. Sent from a fat crate under my desk. Formatting is fine. --