All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/2] qt: Disable QtScript on MIPS64
Date: Wed, 27 Nov 2013 15:03:13 +0100	[thread overview]
Message-ID: <20131127150313.64e3721a@skate> (raw)
In-Reply-To: <1385559761-40501-1-git-send-email-Vincent.Riera@imgtec.com>

Dear Vicente Olivert Riera,

On Wed, 27 Nov 2013 13:42:40 +0000, Vicente Olivert Riera wrote:
> There is no support for MIPS64 in QtScript right now, so buildroot
> upstream suggested to disable the possibility of enabling QtScript on
> MIPS64 as a quick fix for the 2013.11 release:
> 
>    http://lists.busybox.net/pipermail/buildroot/2013-November/083157.html
> 
> A proposed fix to add support for MIPS64 has already been sent to Qt:
> 
>    https://bugreports.qt-project.org/browse/QTBUG-35030
> 
> Fixes:
> 
>    http://autobuild.buildroot.net/results/fd7/fd7e7e53290f235b540ed5f3c784e2584fdb41e0/
> 
> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
> ---
>  package/qt/Config.in |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/package/qt/Config.in b/package/qt/Config.in
> index 2651d55..6fd1c94 100644
> --- a/package/qt/Config.in
> +++ b/package/qt/Config.in
> @@ -385,6 +385,7 @@ config BR2_PACKAGE_QT_OPENSSL
>  
>  config BR2_PACKAGE_QT_SCRIPT
>  	bool "Script Module"
> +	depends on !BR2_mips64el && !BR2_mips64
>  	default y
>  	help
>  	  Build the Qt Script module.

QtScript doesn't build because it uses JavaScriptCore, right? So maybe
we can re-use the existing BR2_PACKAGE_QT_ARCH_SUPPORTS_WEBKIT option,
which already lists which platforms are supported by JavaScriptCore in
Qt4, no?

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  parent reply	other threads:[~2013-11-27 14:03 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-27 13:42 [Buildroot] [PATCH v2 1/2] qt: Disable QtScript on MIPS64 Vicente Olivert Riera
2013-11-27 13:42 ` [Buildroot] [PATCH v2 2/2] grantlee: Disable " Vicente Olivert Riera
2013-11-27 14:03 ` Thomas Petazzoni [this message]
2013-11-27 17:11   ` [Buildroot] [PATCH v2 1/2] qt: Disable QtScript " Vicente Olivert Riera
  -- strict thread matches above, loose matches on Subject: below --
2013-11-27 17:10 Vicente Olivert Riera
2013-11-28 10:26 ` Markos Chandras
2013-11-28 10:28   ` Markos Chandras
2013-11-28 10:48     ` Vicente Olivert Riera
2013-11-28 12:07 ` Thomas Petazzoni
2013-11-28 13:49   ` Vicente Olivert Riera

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131127150313.64e3721a@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.