From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44002) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VlqPa-0008Oa-Oo for qemu-devel@nongnu.org; Wed, 27 Nov 2013 20:29:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VlqPU-0001qJ-Pp for qemu-devel@nongnu.org; Wed, 27 Nov 2013 20:28:58 -0500 Received: from mx1.redhat.com ([209.132.183.28]:49654) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VlqPU-0001pZ-FS for qemu-devel@nongnu.org; Wed, 27 Nov 2013 20:28:52 -0500 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rAS1Sp30003339 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 27 Nov 2013 20:28:51 -0500 Date: Wed, 27 Nov 2013 20:28:50 -0500 From: Luiz Capitulino Message-ID: <20131127202850.36fd6bce@redhat.com> In-Reply-To: <1384426458-24700-1-git-send-email-stefanha@redhat.com> References: <1384426458-24700-1-git-send-email-stefanha@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/5] qemu-io: readline command completion List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Kevin Wolf , qemu-devel@nongnu.org On Thu, 14 Nov 2013 11:54:13 +0100 Stefan Hajnoczi wrote: > This series decouples readline.c from the QEMU monitor and then reuses it in > qemu-io. This adds history and command completion to the qemu-io interactive > prompt. I don't know what's the state of this series, but I reviewed the HMP parts in detail, and took a glance at the qemu-io parts: Reviewed-by: Luiz Capitulino > > Stefan Hajnoczi (5): > readline: decouple readline from the monitor > readline: move readline to a generic location > osdep: add qemu_set_tty_echo() > qemu-io: use readline.c > qemu-io: add command completion > > Makefile.objs | 1 - > hmp.c | 6 +- > include/monitor/monitor.h | 2 +- > include/monitor/readline.h | 56 ----- > include/qemu-io.h | 3 + > include/qemu/osdep.h | 2 + > include/qemu/readline.h | 62 ++++++ > monitor.c | 41 +++- > qemu-io-cmds.c | 15 ++ > qemu-io.c | 109 +++++----- > readline.c | 493 -------------------------------------------- > util/Makefile.objs | 1 + > util/oslib-posix.c | 18 ++ > util/oslib-win32.c | 19 ++ > util/readline.c | 495 +++++++++++++++++++++++++++++++++++++++++++++ > 15 files changed, 716 insertions(+), 607 deletions(-) > delete mode 100644 include/monitor/readline.h > create mode 100644 include/qemu/readline.h > delete mode 100644 readline.c > create mode 100644 util/readline.c >