From: Hagen Paul Pfeifer <hagen@jauu.net>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: David Miller <davem@davemloft.net>,
stefano.salsano@uniroma2.it, netdev@vger.kernel.org
Subject: Re: [PATCH net] netem: fix loss generators
Date: Wed, 27 Nov 2013 22:28:50 +0100 [thread overview]
Message-ID: <20131127212849.GA1428@virgo.local> (raw)
In-Reply-To: <20131121175419.59059598@nehalam.linuxnetplumber.net>
[-- Attachment #1: Type: text/plain, Size: 787 bytes --]
* Stephen Hemminger | 2013-11-21 17:54:19 [-0800]:
>Patch from developers of the alternative loss models, downloaded from:
> http://netgroup.uniroma2.it/twiki/bin/view.cgi/Main/NetemCLG
>
>We found some bugs in our first implementation.
>A first set of bugs is in the function loss_4state:
> In the case 1 of the switch statement in the if conditions we
> need to add clg->a4 to clg->a1, according to the model.
> In the case 3 of the switch statement we need to delete "return
> true" if the condition leads us in the state 1, because the state 1 is
> a good state.
I already fixed the former bug[1]. I cc'ed stefano.salsano@uniroma2.it but did
not get any acked-by/tested-by. The second bug still exists.
Hagen
[1] http://www.spinics.net/lists/netdev/msg255165.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2013-11-27 21:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-22 1:54 [PATCH net] netem: fix loss generators Stephen Hemminger
2013-11-27 21:28 ` Hagen Paul Pfeifer [this message]
2013-11-28 23:18 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131127212849.GA1428@virgo.local \
--to=hagen@jauu.net \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=stefano.salsano@uniroma2.it \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.