From: Antony Pavlov <antonynpavlov@gmail.com>
To: "Andreas Färber" <afaerber@suse.de>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
qemu-devel@nongnu.org, Aurelien Jarno <aurelien@aurel32.net>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH 2/2] hw/mips: use sizes.h macros
Date: Fri, 29 Nov 2013 10:06:48 +0400 [thread overview]
Message-ID: <20131129100648.855ad119d3088f3e561dfe0d@gmail.com> (raw)
In-Reply-To: <529752C6.4040802@suse.de>
On Thu, 28 Nov 2013 15:27:18 +0100
Andreas Färber <afaerber@suse.de> wrote:
> Am 28.11.2013 07:29, schrieb Antony Pavlov:
> > Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
> > Reviewed-by: Richard Henderson <rth@twiddle.net>
>
> Are the int -> long changes caused by the BIT() macro usage? Otherwise I
> would've recommended to put that in a follow-up patch.
Yes, the BIT() macro give us this conversion:
#define BIT(nr) (1UL << (nr))
> But either way,
>
> Reviewed-by: Andreas Färber <afaerber@suse.de>
>
> Andreas
>
> --
> SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
> GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
--
--
Best regards,
Antony Pavlov
next prev parent reply other threads:[~2013-11-29 5:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-28 6:29 [Qemu-devel] [PATCH 0/2] use sizes.h macros for power-of-two sizes Antony Pavlov
2013-11-28 6:29 ` [Qemu-devel] [PATCH 1/2] include/qemu: introduce sizes.h Antony Pavlov
2013-11-28 6:29 ` [Qemu-devel] [PATCH 2/2] hw/mips: use sizes.h macros Antony Pavlov
2013-11-28 14:27 ` Andreas Färber
2013-11-29 6:06 ` Antony Pavlov [this message]
2013-11-28 17:08 ` Stefan Weil
2013-11-29 6:30 ` Antony Pavlov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131129100648.855ad119d3088f3e561dfe0d@gmail.com \
--to=antonynpavlov@gmail.com \
--cc=afaerber@suse.de \
--cc=aurelien@aurel32.net \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.