From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Westerberg Subject: Re: [PATCH] gpio: drop users of irq_set_chip_and_handler_name() Date: Fri, 29 Nov 2013 12:20:51 +0200 Message-ID: <20131129102050.GF2281@intel.com> References: <1385472771-26681-1-git-send-email-linus.walleij@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mga02.intel.com ([134.134.136.20]:36714 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752224Ab3K2KOa (ORCPT ); Fri, 29 Nov 2013 05:14:30 -0500 Content-Disposition: inline In-Reply-To: <1385472771-26681-1-git-send-email-linus.walleij@linaro.org> Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: Linus Walleij Cc: linux-gpio@vger.kernel.org, Alexandre Courbot , David Cohen , Mathias Nyman , Dan Carpenter On Tue, Nov 26, 2013 at 02:32:51PM +0100, Linus Walleij wrote: > Switch all users of irq_set_chip_and_handler_name() to simply > use irq_set_chip_and_handler(), all just provide a boilerplate > name like "demux" or "mux" - a fact which is anyway obvious > from the hwirq number from the irqdomain now present in e.g. > /proc/interrupts. > > Cc: David Cohen > Cc: Mika Westerberg > Cc: Mathias Nyman > Cc: Dan Carpenter > Signed-off-by: Linus Walleij > --- > I'm challenging all users of this function to make an argument > for it to stay in, and suspecting that this is mostly a copy > and paste artifact... I think so also. To me the patch makes perfect sense and it didn't break anything on lynxpoint. For gpio-lynxpoint: Acked-by: Mika Westerberg Tested-by: Mika Westerberg