From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail.skyhub.de ([2a01:4f8:120:8448::d00d]) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1VmRNf-0006WT-PO for kexec@lists.infradead.org; Fri, 29 Nov 2013 16:57:28 +0000 Date: Fri, 29 Nov 2013 17:56:56 +0100 From: Borislav Petkov Subject: Re: [PATCH v4 11/12] x86: reserve setup_data ranges late after parsing memmap cmdline Message-ID: <20131129165656.GF4266@pd.tnic> References: <1385445477-9665-1-git-send-email-dyoung@redhat.com> <1385445477-9665-12-git-send-email-dyoung@redhat.com> <20131127150710.GH32267@pd.tnic> <20131129083551.GB4186@dhcp-16-126.nay.redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20131129083551.GB4186@dhcp-16-126.nay.redhat.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=twosheds.infradead.org@lists.infradead.org To: Dave Young Cc: mjg59@srcf.ucam.org, linux-efi@vger.kernel.org, toshi.kani@hp.com, matt@console-pimps.org, greg@kroah.com, x86@kernel.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, James.Bottomley@HansenPartnership.com, horms@verge.net.au, ebiederm@xmission.com, hpa@zytor.com, vgoyal@redhat.com On Fri, Nov 29, 2013 at 04:35:52PM +0800, Dave Young wrote: > Is below changes ok to you? Almost perfect! Just a micro-nitpick below: > Currently e820_reserve_setup_data is called before parsing early params, > it works in normal case. But for memmap=exactmap, the final memory ranges > are created after parsing memmap= cmdline params, so the previous > e820_reserve_setup_data has no effect. For example for setup_data ranges s/ for/,/ > will still be marked as normal system ram, thus when later sysfs driver > ioremap them kernel will warn about mapping normal ram. > > This patch fix it by moving the e820_reserve_setup_data callback after > parsing early params so they can be set as reserved ranges and later > ioremap will be fine with it. Thanks. -- Regards/Gruss, Boris. Sent from a fat crate under my desk. Formatting is fine. -- _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec From mboxrd@z Thu Jan 1 00:00:00 1970 From: Borislav Petkov Subject: Re: [PATCH v4 11/12] x86: reserve setup_data ranges late after parsing memmap cmdline Date: Fri, 29 Nov 2013 17:56:56 +0100 Message-ID: <20131129165656.GF4266@pd.tnic> References: <1385445477-9665-1-git-send-email-dyoung@redhat.com> <1385445477-9665-12-git-send-email-dyoung@redhat.com> <20131127150710.GH32267@pd.tnic> <20131129083551.GB4186@dhcp-16-126.nay.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: <20131129083551.GB4186-je1gSBvt1TcFLmT5oZ11vB/sF2h8X+2i0E9HWUfgJXw@public.gmane.org> Sender: linux-efi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Dave Young Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, mjg59-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org, hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org, James.Bottomley-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk@public.gmane.org, vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org, horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org, kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, greg-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org, matt-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org, toshi.kani-VXdhtT5mjnY@public.gmane.org List-Id: linux-efi@vger.kernel.org On Fri, Nov 29, 2013 at 04:35:52PM +0800, Dave Young wrote: > Is below changes ok to you? Almost perfect! Just a micro-nitpick below: > Currently e820_reserve_setup_data is called before parsing early params, > it works in normal case. But for memmap=exactmap, the final memory ranges > are created after parsing memmap= cmdline params, so the previous > e820_reserve_setup_data has no effect. For example for setup_data ranges s/ for/,/ > will still be marked as normal system ram, thus when later sysfs driver > ioremap them kernel will warn about mapping normal ram. > > This patch fix it by moving the e820_reserve_setup_data callback after > parsing early params so they can be set as reserved ranges and later > ioremap will be fine with it. Thanks. -- Regards/Gruss, Boris. Sent from a fat crate under my desk. Formatting is fine. -- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932257Ab3K2Q5K (ORCPT ); Fri, 29 Nov 2013 11:57:10 -0500 Received: from mail.skyhub.de ([78.46.96.112]:37493 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932208Ab3K2Q5G (ORCPT ); Fri, 29 Nov 2013 11:57:06 -0500 Date: Fri, 29 Nov 2013 17:56:56 +0100 From: Borislav Petkov To: Dave Young Cc: linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org, x86@kernel.org, mjg59@srcf.ucam.org, hpa@zytor.com, James.Bottomley@HansenPartnership.com, vgoyal@redhat.com, ebiederm@xmission.com, horms@verge.net.au, kexec@lists.infradead.org, greg@kroah.com, matt@console-pimps.org, toshi.kani@hp.com Subject: Re: [PATCH v4 11/12] x86: reserve setup_data ranges late after parsing memmap cmdline Message-ID: <20131129165656.GF4266@pd.tnic> References: <1385445477-9665-1-git-send-email-dyoung@redhat.com> <1385445477-9665-12-git-send-email-dyoung@redhat.com> <20131127150710.GH32267@pd.tnic> <20131129083551.GB4186@dhcp-16-126.nay.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20131129083551.GB4186@dhcp-16-126.nay.redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 29, 2013 at 04:35:52PM +0800, Dave Young wrote: > Is below changes ok to you? Almost perfect! Just a micro-nitpick below: > Currently e820_reserve_setup_data is called before parsing early params, > it works in normal case. But for memmap=exactmap, the final memory ranges > are created after parsing memmap= cmdline params, so the previous > e820_reserve_setup_data has no effect. For example for setup_data ranges s/ for/,/ > will still be marked as normal system ram, thus when later sysfs driver > ioremap them kernel will warn about mapping normal ram. > > This patch fix it by moving the e820_reserve_setup_data callback after > parsing early params so they can be set as reserved ranges and later > ioremap will be fine with it. Thanks. -- Regards/Gruss, Boris. Sent from a fat crate under my desk. Formatting is fine. --