From: "Heiko Stübner" <heiko@sntech.de>
To: Richard Weinberger <richard.weinberger@gmail.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
Rob Herring <rob.herring@calxeda.com>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Stephen Warren <swarren@wwwdotorg.org>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
devicetree@vger.kernel.org,
Grant Likely <grant.likely@linaro.org>,
LKML <linux-kernel@vger.kernel.org>,
rtc-linux@googlegroups.com,
Mike Turquette <mturquette@linaro.org>
Subject: Re: [PATCH v2 2/2] rtc: add hym8563 rtc-driver
Date: Sun, 1 Dec 2013 18:19:25 +0100 [thread overview]
Message-ID: <201312011819.26005.heiko@sntech.de> (raw)
In-Reply-To: <CAFLxGvz6ZYHaDJqc6LPwtPsLUaLuEwSEQaJLZ-hV1m8PxruOow@mail.gmail.com>
Am Sonntag, 1. Dezember 2013, 15:38:40 schrieb Richard Weinberger:
> On Sun, Dec 1, 2013 at 2:39 PM, Heiko Stübner <heiko@sntech.de> wrote:
> > +static int hym8563_probe(struct i2c_client *client,
> > + const struct i2c_device_id *id)
> > +{
> > + struct hym8563 *hym8563;
> > + int ret, gpio_int;
> > +
> > + hym8563 = devm_kzalloc(&client->dev, sizeof(hym8563),
> > GFP_KERNEL);
>
> Shouldn't this be sizeof(*hym8563)?
you're right of course, thanks for catching the missing "*", I'll send a v3
shortly.
Heiko
prev parent reply other threads:[~2013-12-01 17:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-01 13:37 [PATCH v2 0/2] Add support for hym8563 rtcs Heiko Stübner
2013-12-01 13:37 ` Heiko Stübner
[not found] ` <201312011437.47432.heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
2013-12-01 13:38 ` [PATCH v2 1/2] dt-bindings: add hym8563 binding Heiko Stübner
2013-12-01 13:38 ` Heiko Stübner
2013-12-01 13:39 ` [PATCH v2 2/2] rtc: add hym8563 rtc-driver Heiko Stübner
[not found] ` <201312011439.45417.heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
2013-12-01 14:38 ` Richard Weinberger
2013-12-01 14:38 ` Richard Weinberger
2013-12-01 17:19 ` Heiko Stübner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201312011819.26005.heiko@sntech.de \
--to=heiko@sntech.de \
--cc=a.zummo@towertech.it \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mturquette@linaro.org \
--cc=pawel.moll@arm.com \
--cc=richard.weinberger@gmail.com \
--cc=rob.herring@calxeda.com \
--cc=rtc-linux@googlegroups.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.