From: "Pali Rohár" <pali.rohar@gmail.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: sre@ring0.de, sre@debian.org, kernel list <linux-kernel@vger.kernel.org>
Subject: Re: Compile failure on linux-n900 branch -- MEDIA_CAMERA_SUPPORT needed for n900 compilation
Date: Sun, 1 Dec 2013 20:25:13 +0100 [thread overview]
Message-ID: <201312012025.13622@pali> (raw)
In-Reply-To: <20131201192120.GD9743@amd.pavel.ucw.cz>
[-- Attachment #1: Type: Text/Plain, Size: 1778 bytes --]
On Sunday 01 December 2013 20:21:20 Pavel Machek wrote:
> Hi!
>
> I just hit this one:
>
> CC arch/arm/mach-omap2/board-rx51-camera.o
> In file included from
> arch/arm/mach-omap2/board-rx51-camera.c:34:0:
> arch/arm/mach-omap2/../../../drivers/media/platform/omap3isp/
> isp.h: In function 'isp_pad_buffer_type':
> arch/arm/mach-omap2/../../../drivers/media/platform/omap3isp/i
> sp.h:347:19: error: 'const struct v4l2_subdev' has no member
> named 'entity'
> arch/arm/mach-omap2/../../../drivers/media/platform/omap3isp/
> isp.h:350:12: error: 'const struct v4l2_subdev' has no member
> named 'entity' make[1]: ***
> [arch/arm/mach-omap2/board-rx51-camera.o] Error 1 make: ***
> [arch/arm/mach-omap2] Error 2
> make: *** Waiting for unfinished jobs....
> Command exited with non-zero status 2
>
> Problem seems to be that isp.h expects CONFIG_MEDIA_CONTROLLER
> to be set, but board-rx51-camera.c is always compiled. We
> could do
>
> config MACH_NOKIA_RX51
> bool "Nokia N900 (RX-51) phone"
> - depends on ARCH_OMAP3
> + depends on ARCH_OMAP3 && MEDIA_CONTROLLER
> default y
> select OMAP_PACKAGE_CBB
>
> ...but that's cruel to the user. Would this be acceptable?
>
> config MACH_NOKIA_RX51
> bool "Nokia N900 (RX-51) phone"
> depends on ARCH_OMAP3
> default y
> select OMAP_PACKAGE_CBB
> + select MEDIA_CONTROLLER
> + select MEDIA_CAMERA_SUPPORT
>
> Pavel
board-rx51-camera.c is not part of mainline kernel and will never
be (due to DT migration). So maybe it could be better to add
#ifdef to board-rx51-camera.c. Keeping changes for Makefile/Kconfig
files is harder because of future rebase...
--
Pali Rohár
pali.rohar@gmail.com
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2013-12-01 19:25 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-27 12:51 hci_h4p from linux-n900 branch: fix with new bluetooth for 3.13-rc1 Pavel Machek
2013-11-27 14:59 ` Pali Rohár
2013-11-27 19:13 ` Pavel Machek
2013-11-27 19:44 ` Pali Rohár
2013-11-29 23:58 ` Pali Rohár
2013-11-30 17:29 ` Pavel Machek
2013-11-30 23:15 ` device-tree based boot on linux-n900 branch Pavel Machek
2013-12-01 9:50 ` Pali Rohár
2013-12-01 10:24 ` Sebastian Reichel
2013-12-01 19:21 ` Compile failure on linux-n900 branch -- MEDIA_CAMERA_SUPPORT needed for n900 compilation Pavel Machek
2013-12-01 19:25 ` Pali Rohár [this message]
2013-12-01 20:01 ` Pavel Machek
2013-12-01 20:25 ` Pavel Machek
2013-12-01 20:36 ` Pali Rohár
2013-12-02 9:23 ` linux-n900: minor coding style fixes Pavel Machek
2013-12-01 20:29 ` Compile failure on linux-n900 branch -- MEDIA_CAMERA_SUPPORT needed for n900 compilation Pali Rohár
2013-12-01 10:48 ` hci_h4p from linux-n900 branch: fix with new bluetooth for 3.13-rc1 Sebastian Reichel
2013-12-01 11:16 ` Pali Rohár
2013-12-01 11:30 ` Sebastian Reichel
[not found] ` <201312021613.19521@pali>
[not found] ` <20131204122204.GA10262@amd.pavel.ucw.cz>
[not found] ` <201312041732.05400@pali>
2013-12-05 11:56 ` [patch] fix n900 bt error handling Pavel Machek
2013-12-05 13:08 ` Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201312012025.13622@pali \
--to=pali.rohar@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=sre@debian.org \
--cc=sre@ring0.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.