From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RESEND] mfd: mc13xxx: Fix null pointer dereference in mc13xxx_common_init
Date: Mon, 2 Dec 2013 10:56:50 +0000 [thread overview]
Message-ID: <20131202105650.GD29373@lee--X1> (raw)
In-Reply-To: <1385805125.304293643@f433.i.mail.ru>
On Sat, 30 Nov 2013, Alexander Shiyan wrote:
> > On Sat, Nov 30, 2013 at 08:55:37AM +0400, Alexander Shiyan wrote:
> > > If this driver being loaded from devicetree, the pdata is NULL.
> > > This cause kernel Oops when "fsl,mc13xxx-uses-codec" and/or
> > > "fsl,mc13xxx-uses-touch" properties is specified.
> > >
> > > mc13xxx spi0.0: mc13783: rev: 3.3, fin: 0, fab: 0, icid: 2/0
> > > Unable to handle kernel NULL pointer dereference at virtual address 00000018
> ...
> > > - if (mc13xxx->flags & MC13XXX_USE_TOUCHSCREEN)
> > > + if ((mc13xxx->flags & MC13XXX_USE_CODEC) && pdata)
> >
> > Why do we check for CODEC if the Touchscreen should be used?
>
> Oops, my fault, copy/paste bug.
> I'll send the corrected version.
No, please don't.
Just provide proper Device Tree support.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Alexander Shiyan <shc_work@mail.ru>
Cc: Michael Grzeschik <mgr@pengutronix.de>,
Samuel Ortiz <sameo@linux.intel.com>,
linux-kernel@vger.kernel.org,
Sascha Hauer <kernel@pengutronix.de>,
Shawn Guo <shawn.guo@linaro.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH RESEND] mfd: mc13xxx: Fix null pointer dereference in mc13xxx_common_init
Date: Mon, 2 Dec 2013 10:56:50 +0000 [thread overview]
Message-ID: <20131202105650.GD29373@lee--X1> (raw)
In-Reply-To: <1385805125.304293643@f433.i.mail.ru>
On Sat, 30 Nov 2013, Alexander Shiyan wrote:
> > On Sat, Nov 30, 2013 at 08:55:37AM +0400, Alexander Shiyan wrote:
> > > If this driver being loaded from devicetree, the pdata is NULL.
> > > This cause kernel Oops when "fsl,mc13xxx-uses-codec" and/or
> > > "fsl,mc13xxx-uses-touch" properties is specified.
> > >
> > > mc13xxx spi0.0: mc13783: rev: 3.3, fin: 0, fab: 0, icid: 2/0
> > > Unable to handle kernel NULL pointer dereference at virtual address 00000018
> ...
> > > - if (mc13xxx->flags & MC13XXX_USE_TOUCHSCREEN)
> > > + if ((mc13xxx->flags & MC13XXX_USE_CODEC) && pdata)
> >
> > Why do we check for CODEC if the Touchscreen should be used?
>
> Oops, my fault, copy/paste bug.
> I'll send the corrected version.
No, please don't.
Just provide proper Device Tree support.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2013-12-02 10:56 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-30 4:55 [PATCH RESEND] mfd: mc13xxx: Fix null pointer dereference in mc13xxx_common_init Alexander Shiyan
2013-11-30 4:55 ` Alexander Shiyan
2013-11-30 9:34 ` Michael Grzeschik
2013-11-30 9:34 ` Michael Grzeschik
2013-11-30 9:52 ` Alexander Shiyan
2013-11-30 9:52 ` Alexander Shiyan
2013-12-02 10:56 ` Lee Jones [this message]
2013-12-02 10:56 ` Lee Jones
2013-12-02 11:11 ` Alexander Shiyan
2013-12-02 11:11 ` Alexander Shiyan
2013-12-02 11:17 ` Lee Jones
2013-12-02 11:17 ` Lee Jones
2013-12-02 11:53 ` Michael Grzeschik
2013-12-02 11:53 ` Michael Grzeschik
-- strict thread matches above, loose matches on Subject: below --
2013-11-30 9:53 Alexander Shiyan
2013-11-30 9:53 ` Alexander Shiyan
2013-12-02 8:30 ` Philippe Rétornaz
2013-12-02 8:30 ` Philippe Rétornaz
2013-12-02 10:54 ` Lee Jones
2013-12-02 10:54 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131202105650.GD29373@lee--X1 \
--to=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.