All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joe Thornber <thornber@redhat.com>
To: Vincent Pelletier <plr.vincent@gmail.com>
Cc: dm-devel@redhat.com, ejt@redhat.com
Subject: Re: dm-cache: resize_cache_dev resizing to wrong size ?
Date: Mon, 2 Dec 2013 13:18:26 +0000	[thread overview]
Message-ID: <20131202131826.GA30652@debian> (raw)
In-Reply-To: <20131130125842.098ad167@x2>

On Sat, Nov 30, 2013 at 12:58:42PM +0100, Vincent Pelletier wrote:
> Can someone confirm my reading ?

Confirmed.  What confused me for a bit was why the tests were passing:

https://github.com/jthornber/device-mapper-test-suite/blob/master/lib/dmtest/tests/cache/resize_tests.rb

This bug means the superblock *will* record the new cache size, but
the arrays will not be resized.

The cache_check tool needs to be improved to spot this.  At the moment
it just checks that the btree is full of valid array blocks, and
determines missing ranges for damaged trees.  In our case the trees
are fine, just not big enough.

I also think I need to add more tests that force data migration on a
newly resized cache.

Thanks,

- Joe

      reply	other threads:[~2013-12-02 13:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-30 11:58 dm-cache: resize_cache_dev resizing to wrong size ? Vincent Pelletier
2013-12-02 13:18 ` Joe Thornber [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131202131826.GA30652@debian \
    --to=thornber@redhat.com \
    --cc=dm-devel@redhat.com \
    --cc=ejt@redhat.com \
    --cc=plr.vincent@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.