From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
To: David Ahern <dsahern@gmail.com>
Cc: Namhyung Kim <namhyung@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@kernel.org>,
Namhyung Kim <namhyung.kim@lge.com>,
LKML <linux-kernel@vger.kernel.org>, Jiri Olsa <jolsa@redhat.com>,
Stephane Eranian <eranian@google.com>,
Andi Kleen <andi@firstfloor.org>,
Pekka Enberg <penberg@kernel.org>,
Frederic Weisbecker <fweisbec@gmail.com>
Subject: Re: [PATCH 3/3] perf report: Add --show-time-info option
Date: Mon, 2 Dec 2013 17:17:05 -0300 [thread overview]
Message-ID: <20131202201705.GE17149@ghostprotocols.net> (raw)
In-Reply-To: <529CE66B.5070209@gmail.com>
Em Mon, Dec 02, 2013 at 12:58:35PM -0700, David Ahern escreveu:
> On 12/2/13, 12:38 PM, Arnaldo Carvalho de Melo wrote:
> >Can you suggest a better name for the option being discussed?
> >Perhaps one of:
> >--show-event-time
> >--event-time
> >?
>
> Why not just --event-time?
> Really should have dropped the 'show' from the recent perf-script
> change (just --task-events and --mmap-events).
Probably, yeah, Ingo made some point about using --show- for some reason,
Ingo?
One I can think of is that, in general, plain --feature can mean, at
least, one of --enable-feature and --show-feature, so perhaps that is
the point.
But then, perhaps that may be implied by the context, i.e. when
recording, --feature means enable it, while when reporting, what we're
doing is basically _showing_ things, so --feature means just that.
- Arnaldo
> >
> >As a policy I think we should go on adding just long options and only
> >after there is a really strong case we should use a short option for
> >really, really popular options.
>
> And adding options to .perfconfig. Need to use that more.
>
> David
next prev parent reply other threads:[~2013-12-02 20:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-02 19:23 [PATCH 3/3] perf report: Add --show-time-info option Arnaldo Carvalho de Melo
2013-12-02 19:25 ` David Ahern
2013-12-02 19:38 ` Arnaldo Carvalho de Melo
2013-12-02 19:58 ` David Ahern
2013-12-02 20:17 ` Arnaldo Carvalho de Melo [this message]
2013-12-02 20:22 ` David Ahern
2013-12-04 10:11 ` Ingo Molnar
2013-12-04 12:57 ` Arnaldo Carvalho de Melo
-- strict thread matches above, loose matches on Subject: below --
2013-12-02 6:53 [RFC 0/3] perf tools: Show time info (v1) Namhyung Kim
2013-12-02 6:53 ` [PATCH 3/3] perf report: Add --show-time-info option Namhyung Kim
2013-12-02 12:33 ` Arnaldo Carvalho de Melo
2013-12-02 14:38 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131202201705.GE17149@ghostprotocols.net \
--to=acme@ghostprotocols.net \
--cc=a.p.zijlstra@chello.nl \
--cc=andi@firstfloor.org \
--cc=dsahern@gmail.com \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung.kim@lge.com \
--cc=namhyung@kernel.org \
--cc=paulus@samba.org \
--cc=penberg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.