From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] proposed consolidate spin_lock/unlock waiting with spin_unlock_wait
Date: Tue, 03 Dec 2013 07:44:52 +0000 [thread overview]
Message-ID: <20131203074452.GL5443@mwanda> (raw)
In-Reply-To: <20131202145646.GA5126@opentech.at>
On Tue, Dec 03, 2013 at 12:30:32AM +0100, Nicholas Mc Guire wrote:
> > > the api was extended with include/linux/spinlock.h:spin_unlock_wait() for
> > > just this purpose (I think atleast) so the below patch changes these
> > > currently hard-coded spin_lock/unlock to use the available API.
> > > so as its in spinlock.h and the code in question is using spin_lock/unlock
> > > no new header file inclusion is needed.
> >
> > We hopefully can assume you compile tested these so this information
> > about header files is redundant. If you didn't compile test, then we
> > will get really annoyed.
> >
>
> yes but only ran it on a 32 and 64 bit box to test them - but taht would
> at most cover the case in fs so that is very limited. What I did is generate
> the .i files and then looked at the function that got plugged in at that line
> e.g. arch_spin_unlock_wait in the fs/fscache/object.c then checked if that
> should be equivalent. in the arch/cris/arch-v32/drivers/mach-fs/gpio.c
> I contacted the maintainer of the file as I could not figure out what it was
> waiting on (and its UP only).
>
Really, in the case where a cleanup breaks the build people are going to
be annoyed. The traditional thing to do is just to applogize ahead of
time between the --- and the diffstat.
Please note: I don't think this breaks the build but I can't compile it
myself.
regards,
dan carpenter
next prev parent reply other threads:[~2013-12-03 7:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-02 14:56 [PATCH] proposed consolidate spin_lock/unlock waiting with spin_unlock_wait Nicholas Mc Guire
2013-12-02 15:45 ` Dan Carpenter
2013-12-02 23:30 ` Nicholas Mc Guire
2013-12-03 7:44 ` Dan Carpenter [this message]
2013-12-03 11:57 ` Dan Carpenter
2013-12-04 6:17 ` Nicholas Mc Guire
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131203074452.GL5443@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.