From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] tmux: new package 1.8
Date: Tue, 3 Dec 2013 09:41:05 +0100 [thread overview]
Message-ID: <20131203094105.5b299bdb@skate> (raw)
In-Reply-To: <20131202230945.GA6948@gmail.com>
Dear Andrew Ruder,
Thanks for this contribution. On a first look, it seems good. I have
one comment below, though.
On Mon, 2 Dec 2013 17:09:45 -0600, Andrew Ruder wrote:
> Signed-off-by: Andrew Ruder <andrew.ruder@elecsyscorp.com>
> ---
> package/Config.in | 3 +++
> package/tmux/Config.in | 13 +++++++++++++
> package/tmux/tmux.mk | 11 +++++++++++
> 3 files changed, 27 insertions(+)
> create mode 100644 package/tmux/Config.in
> create mode 100644 package/tmux/tmux.mk
>
> diff --git a/package/Config.in b/package/Config.in
> index 40f964b..6fb063d 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -948,6 +948,9 @@ source "package/screen/Config.in"
> source "package/sudo/Config.in"
> if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
> source "package/time/Config.in"
> +endif
> +source "package/tmux/Config.in"
> +if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
> source "package/which/Config.in"
> endif
> source "package/xmlstarlet/Config.in"
> diff --git a/package/tmux/Config.in b/package/tmux/Config.in
> new file mode 100644
> index 0000000..39f83b0
> --- /dev/null
> +++ b/package/tmux/Config.in
> @@ -0,0 +1,13 @@
> +config BR2_PACKAGE_TMUX
> + bool "tmux"
> + select BR2_PACKAGE_LIBEVENT
> + select BR2_PACKAGE_NCURSES
> + depends on BR2_USE_MMU # fork()
> + help
> + tmux is a "terminal multiplexer", it enables
> + a number of terminals (or windows) to be accessed
> + and controlled from a single terminal. tmux is
> + intended to be a simple, modern, BSD-licensed
> + alternative to programs such as GNU screen.
> +
> + http://tmux.sourceforge.net/
> diff --git a/package/tmux/tmux.mk b/package/tmux/tmux.mk
> new file mode 100644
> index 0000000..2ff5e46
> --- /dev/null
> +++ b/package/tmux/tmux.mk
> @@ -0,0 +1,11 @@
> +################################################################################
> +#
> +# tmux
> +#
> +################################################################################
> +
> +TMUX_VERSION = 1.8
> +TMUX_SITE = http://downloads.sourceforge.net/project/tmux/tmux/tmux-$(TMUX_VERSION)
> +TMUX_DEPENDENCIES = ncurses libevent
> +
> +$(eval $(autotools-package))
It would be good to add TMUX_LICENSE and TMUX_LICENSE_FILES.
Other than that, it looks good to me.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2013-12-03 8:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-02 23:09 [Buildroot] [PATCH] tmux: new package 1.8 Andrew Ruder
2013-12-03 8:41 ` Thomas Petazzoni [this message]
2013-12-03 13:32 ` Andrew Ruder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131203094105.5b299bdb@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.