From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH v2 01/15] mfd: menelaus: Drop __exit section annotation Date: Tue, 3 Dec 2013 09:53:22 +0000 Message-ID: <20131203095322.GG11828@lee--X1> References: <1386042188-12246-1-git-send-email-balbi@ti.com> <20131203095136.GF11828@lee--X1> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-ie0-f174.google.com ([209.85.223.174]:54275 "EHLO mail-ie0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751857Ab3LCJx1 (ORCPT ); Tue, 3 Dec 2013 04:53:27 -0500 Received: by mail-ie0-f174.google.com with SMTP id at1so22772680iec.19 for ; Tue, 03 Dec 2013 01:53:27 -0800 (PST) Content-Disposition: inline In-Reply-To: <20131203095136.GF11828@lee--X1> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Felipe Balbi Cc: Linux OMAP Mailing List , Aaro Koskinen , sameo@linux.intel.com, Tony Lindgren , Linux ARM Kernel Mailing List , Linux Kernel Mailing List > The code looks mostly fine, but the implementation of the commit logs > seems lazy. Please submit a v3 using coherent sentences with full > explanations and correct punctuation. Also use the full length of the provided buffer, which I believe is 72 chars, but happy to be correct on that one. It's certainly not 40 chars however. --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-omap" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: lee.jones@linaro.org (Lee Jones) Date: Tue, 3 Dec 2013 09:53:22 +0000 Subject: [PATCH v2 01/15] mfd: menelaus: Drop __exit section annotation In-Reply-To: <20131203095136.GF11828@lee--X1> References: <1386042188-12246-1-git-send-email-balbi@ti.com> <20131203095136.GF11828@lee--X1> Message-ID: <20131203095322.GG11828@lee--X1> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org > The code looks mostly fine, but the implementation of the commit logs > seems lazy. Please submit a v3 using coherent sentences with full > explanations and correct punctuation. Also use the full length of the provided buffer, which I believe is 72 chars, but happy to be correct on that one. It's certainly not 40 chars however. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752921Ab3LCJxa (ORCPT ); Tue, 3 Dec 2013 04:53:30 -0500 Received: from mail-ie0-f179.google.com ([209.85.223.179]:55896 "EHLO mail-ie0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751993Ab3LCJx1 (ORCPT ); Tue, 3 Dec 2013 04:53:27 -0500 Date: Tue, 3 Dec 2013 09:53:22 +0000 From: Lee Jones To: Felipe Balbi Cc: Linux OMAP Mailing List , Aaro Koskinen , sameo@linux.intel.com, Tony Lindgren , Linux ARM Kernel Mailing List , Linux Kernel Mailing List Subject: Re: [PATCH v2 01/15] mfd: menelaus: Drop __exit section annotation Message-ID: <20131203095322.GG11828@lee--X1> References: <1386042188-12246-1-git-send-email-balbi@ti.com> <20131203095136.GF11828@lee--X1> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20131203095136.GF11828@lee--X1> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > The code looks mostly fine, but the implementation of the commit logs > seems lazy. Please submit a v3 using coherent sentences with full > explanations and correct punctuation. Also use the full length of the provided buffer, which I believe is 72 chars, but happy to be correct on that one. It's certainly not 40 chars however. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog