From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH] drm: shmob_drm: Check clk_prepare_enable() return value Date: Tue, 3 Dec 2013 10:59:24 +0100 Message-ID: <20131203095923.GD21178@ulmo.nvidia.com> References: <1385945540-20710-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0003422565==" Return-path: Received: from mail-ea0-f172.google.com (mail-ea0-f172.google.com [209.85.215.172]) by gabe.freedesktop.org (Postfix) with ESMTP id 083DFFAF4A for ; Tue, 3 Dec 2013 02:00:21 -0800 (PST) Received: by mail-ea0-f172.google.com with SMTP id q10so9734615ead.17 for ; Tue, 03 Dec 2013 02:00:21 -0800 (PST) In-Reply-To: <1385945540-20710-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org To: Laurent Pinchart Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0003422565== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="3Pql8miugIZX0722" Content-Disposition: inline --3Pql8miugIZX0722 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Dec 02, 2013 at 01:52:20AM +0100, Laurent Pinchart wrote: [...] > diff --git a/drivers/gpu/drm/shmobile/shmob_drm_crtc.c b/drivers/gpu/drm/= shmobile/shmob_drm_crtc.c [...] > @@ -170,7 +178,9 @@ static void shmob_drm_crtc_start(struct shmob_drm_crt= c *scrtc) > return; > =20 > /* Enable clocks before accessing the hardware. */ > - shmob_drm_clk_on(sdev); > + ret =3D shmob_drm_clk_on(sdev); > + if (ret < 0) > + return; Perhaps this should be printing an error or using WARN_ON()? Otherwise it might be very difficult to diagnose what's going wrong. Thierry --3Pql8miugIZX0722 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJSnat7AAoJEN0jrNd/PrOhEQEQAJoaMPwtXIng7TYBYOxia8c2 KNppUI1k0XVjmgUqA1DtfSmYKkIuPMHzwElzEpSsJAghfHAygU+FJ63F9LTF/qWR y0Eb/sUhzJuf/2C90Ii23uNr5rB9Uy9HspVlv0VO7UPvPq1iEIvPe79LAexz5yVv NHRE2yvmbFMGj4yud2edSvvW60m5DyA+6cFZPJoyiLRv4WWRC04wWEi5gUkGWIL6 hQDMkq8QU9RAWzb2fnk80r3pTXW4W7qYvaOq/5cDRMHEJ6wBezmj4BQdBteEMT2i QMRBn7qlOrUbPLnOuw09spPgK7RyZZNefHyOaRueBBcBLZg4Quj+Fd95oHZS7u/o C0wsOzRNSByrS9Pw9ApGnOarZQl48np9k1T2BOD6tfgzZrbWO6ZWH16M0TctqVdu bSi+2abTgdCAd+iznB8g2aJRZDDL4z6E6gdY4BjNRZuw9YhDNXAZE6KQnyTl9XeL HqGXn7HmslvN0TRs4bLq8Iy3zlHUbSpqlwjjvRgzOad6KEE6aEPpbLnRY9DxIZLL dEs8otO0ehIjuuDILfpu27BDb05Qja9KS/vLuGoV6jlN2sbHbH8M5GlHgzkF9dKg WyDgWn3Zszjsclsv5DVWqxN2oWQsQfE2rq9ooFwPYhCXoE5lpg2G1fGUGpo4rBoB t+I4DsxedngVWX2olkcQ =WPVN -----END PGP SIGNATURE----- --3Pql8miugIZX0722-- --===============0003422565== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============0003422565==--